Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2842373002: Initialize |selection_popup_controller_| properly (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_android.h" 5 #include "content/browser/renderer_host/render_widget_host_view_android.h"
6 6
7 #include <android/bitmap.h> 7 #include <android/bitmap.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 latest_confirmed_begin_frame_source_id_(0), 439 latest_confirmed_begin_frame_source_id_(0),
440 latest_confirmed_begin_frame_sequence_number_( 440 latest_confirmed_begin_frame_sequence_number_(
441 cc::BeginFrameArgs::kInvalidFrameNumber), 441 cc::BeginFrameArgs::kInvalidFrameNumber),
442 outstanding_begin_frame_requests_(0), 442 outstanding_begin_frame_requests_(0),
443 is_showing_(!widget_host->is_hidden()), 443 is_showing_(!widget_host->is_hidden()),
444 is_window_visible_(true), 444 is_window_visible_(true),
445 is_window_activity_started_(true), 445 is_window_activity_started_(true),
446 is_in_vr_(false), 446 is_in_vr_(false),
447 content_view_core_(nullptr), 447 content_view_core_(nullptr),
448 ime_adapter_android_(nullptr), 448 ime_adapter_android_(nullptr),
449 selection_popup_controller_(nullptr),
449 background_color_(SK_ColorWHITE), 450 background_color_(SK_ColorWHITE),
450 cached_background_color_(SK_ColorWHITE), 451 cached_background_color_(SK_ColorWHITE),
451 view_(this), 452 view_(this),
452 gesture_provider_(ui::GetGestureProviderConfig( 453 gesture_provider_(ui::GetGestureProviderConfig(
453 ui::GestureProviderConfigType::CURRENT_PLATFORM), 454 ui::GestureProviderConfigType::CURRENT_PLATFORM),
454 this), 455 this),
455 stylus_text_selector_(this), 456 stylus_text_selector_(this),
456 using_browser_compositor_(CompositorImpl::IsInitialized()), 457 using_browser_compositor_(CompositorImpl::IsInitialized()),
457 synchronous_compositor_client_(nullptr), 458 synchronous_compositor_client_(nullptr),
458 frame_evictor_(new viz::FrameEvictor(this)), 459 frame_evictor_(new viz::FrameEvictor(this)),
(...skipping 1731 matching lines...) Expand 10 before | Expand all | Expand 10 after
2190 2191
2191 ui::WindowAndroidCompositor* compositor = window_android->GetCompositor(); 2192 ui::WindowAndroidCompositor* compositor = window_android->GetCompositor();
2192 if (!compositor) 2193 if (!compositor)
2193 return; 2194 return;
2194 2195
2195 overscroll_controller_ = base::MakeUnique<OverscrollControllerAndroid>( 2196 overscroll_controller_ = base::MakeUnique<OverscrollControllerAndroid>(
2196 overscroll_refresh_handler, compositor, view_.GetDipScale()); 2197 overscroll_refresh_handler, compositor, view_.GetDipScale());
2197 } 2198 }
2198 2199
2199 } // namespace content 2200 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698