Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2842313002:
Add two large table collapsed border performance tests (Closed)
DescriptionAdd two large table collapsed border performance tests
They will show improvement of upcoming optimization changes.
Review-Url: https://codereview.chromium.org/2842313002
Cr-Commit-Position: refs/heads/master@{#467598}
Committed: https://chromium.googlesource.com/chromium/src/+/4dc75a6309ee25e843244e51eb42623230193ba0
Patch Set 1 #
Total comments: 2
Messages
Total messages: 21 (16 generated)
wangxianzhu@chromium.org changed reviewers: + pdr@chromium.org
One test is under Mutation and another is under Paint because the former triggers both layout and repaint, and the latter triggers repaint only. For the latter as a blink_perf.paint test we also measure prePaint and paintTree times.
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Add two large table collapsed border performance tests They will show improvement of upcoming optimization changes. ========== to ========== Add two large table collapsed border performance tests They will show improvement of upcoming optimization changes. TBR=pdr@chromium.org ==========
Description was changed from ========== Add two large table collapsed border performance tests They will show improvement of upcoming optimization changes. TBR=pdr@chromium.org ========== to ========== Add two large table collapsed border performance tests They will show improvement of upcoming optimization changes. ==========
Description was changed from ========== Add two large table collapsed border performance tests They will show improvement of upcoming optimization changes. ========== to ========== Add two large table collapsed border performance tests They will show improvement of upcoming optimization changes. TBR=pdr@chromium.org ==========
Description was changed from ========== Add two large table collapsed border performance tests They will show improvement of upcoming optimization changes. TBR=pdr@chromium.org ========== to ========== Add two large table collapsed border performance tests They will show improvement of upcoming optimization changes. ==========
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM https://codereview.chromium.org/2842313002/diff/1/third_party/WebKit/Performa... File third_party/WebKit/PerformanceTests/Mutation/large-table-row-height-change-with-collapsed-border.html (right): https://codereview.chromium.org/2842313002/diff/1/third_party/WebKit/Performa... third_party/WebKit/PerformanceTests/Mutation/large-table-row-height-change-with-collapsed-border.html:27: run: function() { Optional: can you move the setup into setup() and add a done() function which cleans up the dom before printing the results (like https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/Pain...
https://codereview.chromium.org/2842313002/diff/1/third_party/WebKit/Performa... File third_party/WebKit/PerformanceTests/Mutation/large-table-row-height-change-with-collapsed-border.html (right): https://codereview.chromium.org/2842313002/diff/1/third_party/WebKit/Performa... third_party/WebKit/PerformanceTests/Mutation/large-table-row-height-change-with-collapsed-border.html:27: run: function() { On 2017/04/27 05:18:56, pdr. wrote: > Optional: can you move the setup into setup() and add a done() function which > cleans up the dom before printing the results (like > https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/Pain... Good idea! I will address this in a follow-up, including other tests.
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493272564832800, "parent_rev":
"5fdb3237636167dfb535cd5ef8a535e5b9f8b662", "commit_rev":
"4dc75a6309ee25e843244e51eb42623230193ba0"}
Message was sent while issue was closed.
Description was changed from ========== Add two large table collapsed border performance tests They will show improvement of upcoming optimization changes. ========== to ========== Add two large table collapsed border performance tests They will show improvement of upcoming optimization changes. Review-Url: https://codereview.chromium.org/2842313002 Cr-Commit-Position: refs/heads/master@{#467598} Committed: https://chromium.googlesource.com/chromium/src/+/4dc75a6309ee25e843244e51eb42... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/4dc75a6309ee25e843244e51eb42... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
