third_party/WebKit/PerformanceTests/Mutation/large-table-row-height-change-with-collapsed-border.html - Issue 2842313002: Add two large table collapsed border performance tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/PerformanceTests/Mutation/large-table-row-height-change-with-collapsed-border.html

Issue 2842313002: Add two large table collapsed border performance tests (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/PerformanceTests/Paint/large-table-background-change-with-zero-width-collapsed-borders.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <script src="../resources/runner.js"></script>

	4 <style>td { border: 1px solid blue }</style>

	5 <script>

	6 function createTable(rows, columns) {

	7 var table = document.createElement("TABLE");

	8 // Collapsing border is not necessary to see the slowness

	9 // but it makes the painting phase ~2x slower.

	10 table.style.borderCollapse = "collapse";

	11 for (var i = 0; i < rows; ++i) {

	12 var tr = document.createElement("TR");

	13 for (var j = 0; j < columns; ++j) {

	14 var td = document.createElement("TD");

	15 tr.appendChild(td);

	16 }

	17 table.appendChild(tr);

	18 }

	19 return table;

	20 }

	21

	22 var table = createTable(400, 400);

	23 document.body.appendChild(table);

	24

	25 var y = 0;

	26 PerfTestRunner.measureFrameTime({

	27 run: function() {
	pdr. 2017/04/27 05:18:56 Optional: can you move the setup into setup() and Optional: can you move the setup into setup() and add a done() function which cleans up the dom before printing the results (like https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/Pain... Xianzhu 2017/04/27 05:56:00 Good idea! I will address this in a follow-up, inc Show quoted text On 2017/04/27 05:18:56, pdr. wrote: > Optional: can you move the setup into setup() and add a done() function which > cleans up the dom before printing the results (like > https://cs.chromium.org/chromium/src/third_party/WebKit/PerformanceTests/Pain... Good idea! I will address this in a follow-up, including other tests.
	28 table.childNodes[y].style.height = '20px';

	29 y++;

	30 },

	31 });

	32 </script>

	33 </body>

OLD	NEW