"Open in new chrome tab" and "open in incognito tab" missing for images in context menu CCT.

"Open in new chrome tab" and "open in incognito tab" missing for images in context menu CCT.

This is a regression bug because the recent fix checked the wrong field.
If the url of a image is empty and blank, both two options should be
hidden. However, for images and video, the urls are stored in the srcUrl
instead of linkUrl. Also if the url is emtpy, the "open in [default
browser]" option should also be hidden.

BUG=715381
Review-Url: https://codereview.chromium.org/2842303002
Cr-Commit-Position: refs/heads/master@{#467571}
Committed: https://chromium.googlesource.com/chromium/src/+/2236c8e01131fe9f2d02056a04d7494188d83a23

[ltian, 2017-04-26 21:35:20]

ltian@chromium.org changed reviewers:
+ tedchoc@chromium.org

[ltian, 2017-04-26 21:35:20]

Could you take a look of my change in this CL?

Thanks!

[Ted C, 2017-04-27 00:08:07]

lgtm

https://codereview.chromium.org/2842303002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/2842303002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:399:
if (TextUtils.isEmpty(params.getLinkUrl())
should we use isEmptyUrl here?

[ltian, 2017-04-27 00:37:23]

https://codereview.chromium.org/2842303002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
(right):

https://codereview.chromium.org/2842303002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java:399:
if (TextUtils.isEmpty(params.getLinkUrl())
On 2017/04/27 00:08:07, Ted C wrote:
> should we use isEmptyUrl here?

Done.

[ltian, 2017-04-27 00:38:29]

The CQ bit was checked by ltian@chromium.org

[ltian, 2017-04-27 00:38:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2842303002/#ps20001
(title: "Update Ted's nit.")

[commit-bot: I haz the power, 2017-04-27 00:39:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 03:44:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493253509549050,
"parent_rev": "9aca3b818102de16d10579f4f3157527ed69116a", "commit_rev":
"2236c8e01131fe9f2d02056a04d7494188d83a23"}

[commit-bot: I haz the power, 2017-04-27 03:44:28]

Description was changed from

==========
"Open in new chrome tab" and "open in incognito tab" missing for images in
context menu CCT.

This is a regression bug because the recent fix checked the wrong field.
If the url of a image is empty and blank, both two options should be
hidden. However, for images and video, the urls are stored in the srcUrl
instead of linkUrl. Also if the url is emtpy, the "open in [default
browser]" option should also be hidden.

BUG=715381
==========

to

==========
"Open in new chrome tab" and "open in incognito tab" missing for images in
context menu CCT.

This is a regression bug because the recent fix checked the wrong field.
If the url of a image is empty and blank, both two options should be
hidden. However, for images and video, the urls are stored in the srcUrl
instead of linkUrl. Also if the url is emtpy, the "open in [default
browser]" option should also be hidden.

BUG=715381

Review-Url: https://codereview.chromium.org/2842303002
Cr-Commit-Position: refs/heads/master@{#467571}
Committed:
https://chromium.googlesource.com/chromium/src/+/2236c8e01131fe9f2d02056a04d7...
==========

[commit-bot: I haz the power, 2017-04-27 03:44:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2236c8e01131fe9f2d02056a04d7...