"Open in new chrome tab" and "open in incognito tab" missing for images in context menu CCT.

chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.contextmenu;
 
 import android.content.Context;
 import android.net.MailTo;
 import android.support.annotation.IntDef;
 import android.support.annotation.StringRes;
@@ skipping 378 matching lines @@
         if (params.getLinkText().trim().isEmpty() || params.isImage()) {
             disabledOptions.add(ContextMenuItem.COPY_LINK_TEXT);
         }
 
         if (params.isAnchor() && !UrlUtilities.isAcceptedScheme(params.getLinkUrl())) {
             disabledOptions.add(ContextMenuItem.OPEN_IN_OTHER_WINDOW);
             disabledOptions.add(ContextMenuItem.OPEN_IN_NEW_TAB);
             disabledOptions.add(ContextMenuItem.OPEN_IN_INCOGNITO_TAB);
         }
 
         if (TextUtils.isEmpty(params.getLinkUrl())

[Ted C, 2017/04/27 00:08:07]

should we use isEmptyUrl here?

[ltian, 2017/04/27 00:37:23]

Done.

                 || params.getLinkUrl().equals(ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL)) {
             disabledOptions.add(ContextMenuItem.OPEN_IN_OTHER_WINDOW);
             disabledOptions.add(ContextMenuItem.OPEN_IN_NEW_TAB);
             disabledOptions.add(ContextMenuItem.OPEN_IN_INCOGNITO_TAB);
-            disabledOptions.add(ContextMenuItem.OPEN_IN_CHROME_INCOGNITO_TAB);
-            disabledOptions.add(ContextMenuItem.OPEN_IN_NEW_CHROME_TAB);
         }
 
         if (MailTo.isMailTo(params.getLinkUrl())) {
             disabledOptions.add(ContextMenuItem.COPY_LINK_TEXT);
             disabledOptions.add(ContextMenuItem.COPY_LINK_ADDRESS);
             if (!mDelegate.supportsSendEmailMessage()) {
                 disabledOptions.add(ContextMenuItem.SEND_MESSAGE);
             }
             if (TextUtils.isEmpty(MailTo.parse(params.getLinkUrl()).getTo())
                     || !mDelegate.supportsAddToContacts()) {
@@ skipping 61 matching lines @@
             disabledOptions.add(ContextMenuItem.OPEN_IN_OTHER_WINDOW);
             disabledOptions.add(ContextMenuItem.OPEN_IN_NEW_TAB);
             disabledOptions.add(ContextMenuItem.OPEN_IN_INCOGNITO_TAB);
             disabledOptions.add(ContextMenuItem.SEARCH_BY_IMAGE);
             disabledOptions.add(ContextMenuItem.OPEN_IN_CHROME);
         }
 
         if (mMode == CUSTOM_TAB_MODE) {
             try {
                 URI uri = new URI(getUrl(params));
-                if (UrlUtilities.isInternalScheme(uri)) {
+                if (UrlUtilities.isInternalScheme(uri) || isEmptyUrl(getUrl(params))) {
                     disabledOptions.add(ContextMenuItem.OPEN_IN_NEW_CHROME_TAB);
                     disabledOptions.add(ContextMenuItem.OPEN_IN_CHROME_INCOGNITO_TAB);
                     disabledOptions.add(ContextMenuItem.OPEN_IN_BROWSER_ID);
                 } else if (ChromePreferenceManager.getInstance().getCachedChromeDefaultBrowser()) {
                     disabledOptions.add(ContextMenuItem.OPEN_IN_BROWSER_ID);
                     if (!mDelegate.isIncognitoSupported()) {
                         disabledOptions.add(ContextMenuItem.OPEN_IN_CHROME_INCOGNITO_TAB);
                     }
                 } else {
                     disabledOptions.add(ContextMenuItem.OPEN_IN_NEW_CHROME_TAB);
@@ skipping 102 matching lines @@
             ContextMenuUma.record(params, ContextMenuUma.ACTION_OPEN_IN_BROWSER);
             mDelegate.onOpenInDefaultBrowser(getUrl(params));
         } else {
             assert false;
         }
 
         return true;
     }
 
     /**
+     * Checks whether a url is empty or blank.
+     * @param url The url need to be checked.
+     * @return True if the url is empty or "about:blank".
+     */
+    private boolean isEmptyUrl(String url) {
+        if (TextUtils.isEmpty(url) || url.equals(ContentUrlConstants.ABOUT_BLANK_DISPLAY_URL)) {
+            return true;
+        }
+        return false;
+    }
+
+    /**
      * The valid url of a link is stored in the linkUrl of ContextMenuParams while the
      * valid url of a image or video is stored in the srcUrl of ContextMenuParams.
      * @param params The parameters used to decide the type of the content.
      */
     private String getUrl(ContextMenuParams params) {
         if (params.isImage() || params.isVideo()) {
             return params.getSrcUrl();
         } else {
             return params.getLinkUrl();
         }
     }
 }