Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2842213002: MediaStreamAudioDestination channelCountMode is "explicit" (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, haraken, blink-reviews, Raymond Toy, hongchan
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaStreamAudioDestination channelCountMode is "explicit" The channelCountMode was "max", but it should be "explicit", per the WebAudio spec. BUG=715128 TEST=constructor/mediastreamaudiodestination.html Review-Url: https://codereview.chromium.org/2842213002 Cr-Commit-Position: refs/heads/master@{#472855} Committed: https://chromium.googlesource.com/chromium/src/+/0ef534a188b3a115411b8b351f2e6e4070bba2e6

Patch Set 1 #

Patch Set 2 : Update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiodestination.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 53 (27 generated)
Raymond Toy
PTAL
3 years, 7 months ago (2017-05-08 21:23:04 UTC) #3
hongchan
lgtm
3 years, 7 months ago (2017-05-10 15:20:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842213002/20001
3 years, 7 months ago (2017-05-10 15:59:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450304)
3 years, 7 months ago (2017-05-10 17:51:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842213002/20001
3 years, 7 months ago (2017-05-10 19:44:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450619)
3 years, 7 months ago (2017-05-10 21:52:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842213002/20001
3 years, 7 months ago (2017-05-11 14:41:32 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451783)
3 years, 7 months ago (2017-05-11 16:31:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842213002/20001
3 years, 7 months ago (2017-05-11 17:29:19 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/176132)
3 years, 7 months ago (2017-05-11 19:24:43 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842213002/20001
3 years, 7 months ago (2017-05-12 15:22:54 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/369356)
3 years, 7 months ago (2017-05-12 18:10:15 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842213002/20001
3 years, 7 months ago (2017-05-12 19:44:49 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/453366)
3 years, 7 months ago (2017-05-12 19:58:55 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842213002/20001
3 years, 7 months ago (2017-05-15 16:00:49 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/444599)
3 years, 7 months ago (2017-05-15 19:18:54 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842213002/20001
3 years, 7 months ago (2017-05-16 14:39:33 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/455985)
3 years, 7 months ago (2017-05-16 17:46:23 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842213002/20001
3 years, 7 months ago (2017-05-16 20:19:55 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/456522)
3 years, 7 months ago (2017-05-16 23:25:19 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842213002/20001
3 years, 7 months ago (2017-05-17 15:33:09 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457521)
3 years, 7 months ago (2017-05-17 17:15:27 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842213002/20001
3 years, 7 months ago (2017-05-17 19:26:26 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457950)
3 years, 7 months ago (2017-05-17 21:37:51 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2842213002/20001
3 years, 7 months ago (2017-05-18 15:14:47 UTC) #50
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 17:17:46 UTC) #53
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0ef534a188b3a115411b8b351f2e...

Powered by Google App Engine
This is Rietveld 408576698