|
|
Created:
3 years, 8 months ago by Raymond Toy Modified:
3 years, 7 months ago Reviewers:
hongchan CC:
chromium-reviews, haraken, blink-reviews, Raymond Toy, hongchan Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMediaStreamAudioDestination channelCountMode is "explicit"
The channelCountMode was "max", but it should be "explicit", per the
WebAudio spec.
BUG=715128
TEST=constructor/mediastreamaudiodestination.html
Review-Url: https://codereview.chromium.org/2842213002
Cr-Commit-Position: refs/heads/master@{#472855}
Committed: https://chromium.googlesource.com/chromium/src/+/0ef534a188b3a115411b8b351f2e6e4070bba2e6
Patch Set 1 #Patch Set 2 : Update test #
Messages
Total messages: 53 (27 generated)
Description was changed from ========== MediaStreamAudioDestination channelCountMode is "explicit" The channelCountMode was "max", but it should be "explicit", per the WebAudio spec. BUG=715128 TEST= ========== to ========== MediaStreamAudioDestination channelCountMode is "explicit" The channelCountMode was "max", but it should be "explicit", per the WebAudio spec. BUG=715128 TEST=constructor/mediastreamaudiodestination.html ==========
rtoy@chromium.org changed reviewers: + hongchan@chromium.org
PTAL
lgtm
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495120443248180, "parent_rev": "9102badab31062609acf65f4ddf9c3a332e85705", "commit_rev": "0ef534a188b3a115411b8b351f2e6e4070bba2e6"}
Message was sent while issue was closed.
Description was changed from ========== MediaStreamAudioDestination channelCountMode is "explicit" The channelCountMode was "max", but it should be "explicit", per the WebAudio spec. BUG=715128 TEST=constructor/mediastreamaudiodestination.html ========== to ========== MediaStreamAudioDestination channelCountMode is "explicit" The channelCountMode was "max", but it should be "explicit", per the WebAudio spec. BUG=715128 TEST=constructor/mediastreamaudiodestination.html Review-Url: https://codereview.chromium.org/2842213002 Cr-Commit-Position: refs/heads/master@{#472855} Committed: https://chromium.googlesource.com/chromium/src/+/0ef534a188b3a115411b8b351f2e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0ef534a188b3a115411b8b351f2e... |