Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 2842143002: cros: Prevent casual shut down and power save during migration. (Closed)

Created:
3 years, 8 months ago by fukino
Modified:
3 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

cros: Prevent casual shut down and power save during migration. In the migration UI, we ask users that "Don't turn off or close your Chromebook". In addition, we can resume migration even when user shut down / suspend the device during migration. That said, it should be even safer to prevent casual shutdown and power save mode by: - Hide "Shut down" button during migration. - Block power save during migration. Note that if the user close the lid, the system will be suspended. We have heard about heat issues when the lid is closed, and the system will be heated by heavy CPU usage of migration. It should be safer not to keep the device awake when the lid is closed. BUG=711454 TEST=manually tested that the "Shut down" button was hidden and the device did not go to sleep mode during migration. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2842433002 Cr-Commit-Position: refs/heads/master@{#466879} (cherry picked from commit e88b030f517ff578aff9af1a5a7762fc313163ad) Review-Url: https://codereview.chromium.org/2842143002 . Cr-Commit-Position: refs/branch-heads/3071@{#222} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/55a06d1004b127df1fde63455dcb6cdd458714e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
M chrome/browser/resources/chromeos/login/header_bar.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_encryption_migration.js View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h View 4 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc View 4 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
3 years, 8 months ago (2017-04-26 10:46:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
55a06d1004b127df1fde63455dcb6cdd458714e2.

Powered by Google App Engine
This is Rietveld 408576698