cros: Prevent casual shut down and power save during migration.

cros: Prevent casual shut down and power save during migration.

In the migration UI, we ask users that "Don't turn off or close your Chromebook".
In addition, we can resume migration even when user shut down / suspend the device
during migration.

That said, it should be even safer to prevent casual shutdown and power save mode by:
- Hide "Shut down" button during migration.
- Block power save during migration.

Note that if the user close the lid, the system will be suspended.
We have heard about heat issues when the lid is closed, and the system will be
heated by heavy CPU usage of migration.
It should be safer not to keep the device awake when the lid is closed.

BUG=711454
TEST=manually tested that the "Shut down" button was hidden and the device did
not go to sleep mode during migration.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2842433002
Cr-Commit-Position: refs/heads/master@{#466879}
Committed: https://chromium.googlesource.com/chromium/src/+/e88b030f517ff578aff9af1a5a7762fc313163ad

[fukino, 2017-04-24 12:28:59]

Description was changed from

==========
cros: Prevent casual shut down and power save during migration.

In the migration UI, we ask users that "Don't turn off or close your
Chromebook".
In addition, we can resume migration even when user shut down / suspend the
device
during migration.

That said, it shoudl be even safer to prevent casual shutdown and power save
mode by:
- Hide "Shut down" button during migraiton.
- Block power save durgin migration.

Note that if the user close the lid, the system will be suspended.
We have heard about heat issues when the lid is closed, and the system will be
heated by heavy CPU usage of migration.
It should be safer not to keep the device awake when the lid is closed.

BUG=711454
TEST=manually tested that the "Shut down" button was hidden and the device did
not go to sleep mode during migraiton.
==========

to

==========
cros: Prevent casual shut down and power save during migration.

In the migration UI, we ask users that "Don't turn off or close your
Chromebook".
In addition, we can resume migration even when user shut down / suspend the
device
during migration.

That said, it shoudl be even safer to prevent casual shutdown and power save
mode by:
- Hide "Shut down" button during migraiton.
- Block power save durgin migration.

Note that if the user close the lid, the system will be suspended.
We have heard about heat issues when the lid is closed, and the system will be
heated by heavy CPU usage of migration.
It should be safer not to keep the device awake when the lid is closed.

BUG=711454
TEST=manually tested that the "Shut down" button was hidden and the device did
not go to sleep mode during migraiton.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-04-24 12:31:24]

fukino@chromium.org changed reviewers:
+ xiyuan@chromium.org

[fukino, 2017-04-24 12:31:25]

Xiyuan, could you take a look?

https://codereview.chromium.org/2842433002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/header_bar.css (right):

https://codereview.chromium.org/2842433002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/header_bar.css:9: min-height: 34px;  /*
Should be consistent with .header-bar-item's height. */
When all header-bar-items are hidden, the header bar gets thinner, which does
not look good (since there still are some GUI elements like current time etc...
on the header).
That's why I explicitly set height here.

[fukino, 2017-04-24 12:31:31]

The CQ bit was checked by fukino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 12:31:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 12:43:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 12:43:09]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[xiyuan, 2017-04-24 16:35:29]

Description was changed from

==========
cros: Prevent casual shut down and power save during migration.

In the migration UI, we ask users that "Don't turn off or close your
Chromebook".
In addition, we can resume migration even when user shut down / suspend the
device
during migration.

That said, it shoudl be even safer to prevent casual shutdown and power save
mode by:
- Hide "Shut down" button during migraiton.
- Block power save durgin migration.

Note that if the user close the lid, the system will be suspended.
We have heard about heat issues when the lid is closed, and the system will be
heated by heavy CPU usage of migration.
It should be safer not to keep the device awake when the lid is closed.

BUG=711454
TEST=manually tested that the "Shut down" button was hidden and the device did
not go to sleep mode during migraiton.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Prevent casual shut down and power save during migration.

In the migration UI, we ask users that "Don't turn off or close your
Chromebook".
In addition, we can resume migration even when user shut down / suspend the
device
during migration.

That said, it should be even safer to prevent casual shutdown and power save
mode by:
- Hide "Shut down" button during migration.
- Block power save during migration.

Note that if the user close the lid, the system will be suspended.
We have heard about heat issues when the lid is closed, and the system will be
heated by heavy CPU usage of migration.
It should be safer not to keep the device awake when the lid is closed.

BUG=711454
TEST=manually tested that the "Shut down" button was hidden and the device did
not go to sleep mode during migration.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[xiyuan, 2017-04-24 16:48:52]

lgtm

You need to add

  "//device/power_save_blocker",

to a deps somewhere in chrome/browser/ui/BUILD.gn. Maybe the chromeos specific
one, [1]

[1]:
https://cs.chromium.org/chromium/src/chrome/browser/ui/BUILD.gn?rcl=97dde4e68...

After update BUILD.gn, we can run "gn check out/Debug" on dev box to check.

https://codereview.chromium.org/2842433002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/header_bar.css (right):

https://codereview.chromium.org/2842433002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/header_bar.css:9: min-height: 34px;  /*
Should be consistent with .header-bar-item's height. */
On 2017/04/24 12:31:24, fukino wrote:
> When all header-bar-items are hidden, the header bar gets thinner, which does
> not look good (since there still are some GUI elements like current time
etc...
> on the header).
> That's why I explicitly set height here.

Acknowledged.

[fukino, 2017-04-25 03:35:45]

The CQ bit was checked by fukino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 03:36:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 04:32:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 04:32:13]

Dry run: This issue passed the CQ dry run.

[fukino, 2017-04-25 05:01:19]

Thank you!
I updated BUILD.gn.
I'll do "gn check" next time I include a new header.

[fukino, 2017-04-25 05:01:25]

The CQ bit was checked by fukino@chromium.org

[fukino, 2017-04-25 05:01:25]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2842433002/#ps20001
(title: "Update BUILD.gn to include PowerSaveBlocker.")

[commit-bot: I haz the power, 2017-04-25 05:02:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 05:18:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493096485239620,
"parent_rev": "e90ed61ee27f039c110fea16425a723f82bdbaf9", "commit_rev":
"e88b030f517ff578aff9af1a5a7762fc313163ad"}

[commit-bot: I haz the power, 2017-04-25 05:19:01]

Description was changed from

==========
cros: Prevent casual shut down and power save during migration.

In the migration UI, we ask users that "Don't turn off or close your
Chromebook".
In addition, we can resume migration even when user shut down / suspend the
device
during migration.

That said, it should be even safer to prevent casual shutdown and power save
mode by:
- Hide "Shut down" button during migration.
- Block power save during migration.

Note that if the user close the lid, the system will be suspended.
We have heard about heat issues when the lid is closed, and the system will be
heated by heavy CPU usage of migration.
It should be safer not to keep the device awake when the lid is closed.

BUG=711454
TEST=manually tested that the "Shut down" button was hidden and the device did
not go to sleep mode during migration.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Prevent casual shut down and power save during migration.

In the migration UI, we ask users that "Don't turn off or close your
Chromebook".
In addition, we can resume migration even when user shut down / suspend the
device
during migration.

That said, it should be even safer to prevent casual shutdown and power save
mode by:
- Hide "Shut down" button during migration.
- Block power save during migration.

Note that if the user close the lid, the system will be suspended.
We have heard about heat issues when the lid is closed, and the system will be
heated by heavy CPU usage of migration.
It should be safer not to keep the device awake when the lid is closed.

BUG=711454
TEST=manually tested that the "Shut down" button was hidden and the device did
not go to sleep mode during migration.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2842433002
Cr-Commit-Position: refs/heads/master@{#466879}
Committed:
https://chromium.googlesource.com/chromium/src/+/e88b030f517ff578aff9af1a5a77...
==========

[commit-bot: I haz the power, 2017-04-25 05:19:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e88b030f517ff578aff9af1a5a77...