Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2842103002:
Image Capture: two small nits (Closed)
|
Created:
3 years, 8 months ago by mcasas Modified:
3 years, 7 months ago Reviewers:
Reilly Grant (use Gerrit) CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, blink-reviews, feature-media-reviews_chromium.org, mcasas+imagecapture_chromium.org, agrieve+watch_chromium.org, haraken, xjz+watch_chromium.org, miu+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionImage Capture: two small nits
Android Auto Exposure is always available, make the implementation
reflect that.
In blink, don't fill dictionary entries with empty arrays.
BUG=716636
Review-Url: https://codereview.chromium.org/2842103002
Cr-Commit-Position: refs/heads/master@{#468205}
Committed: https://chromium.googlesource.com/chromium/src/+/b6da435540cdb1774a04fcf9a45c98158caf299c
Patch Set 1 : rebase #
Total comments: 4
Patch Set 2 : reillyg@ nits #Patch Set 3 : reworded comment on supported exposure modes #
Messages
Total messages: 26 (20 generated)
The CQ bit was checked by mcasas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
Patchset #1 (id:1) has been deleted
Description was changed from ========== [wip] Image Capture: AE is always available, don't fill dictionaries with emtpy arrays some small thingies BUG= ========== to ========== Image Capture: two small nits Android Auto Exposure is always available, make the implementation reflect that. In blink, don't fill dictionary entries with empty arrays. BUG= ==========
Description was changed from ========== Image Capture: two small nits Android Auto Exposure is always available, make the implementation reflect that. In blink, don't fill dictionary entries with empty arrays. BUG= ========== to ========== Image Capture: two small nits Android Auto Exposure is always available, make the implementation reflect that. In blink, don't fill dictionary entries with empty arrays. BUG=716636 ==========
mcasas@chromium.org changed reviewers: + reillyg@chromium.org
reillyg@ tiny CL PTAL
The CQ bit was checked by mcasas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2842103002/diff/20001/media/capture/video/and... File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java (right): https://codereview.chromium.org/2842103002/diff/20001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:536: // Auto Exposure is the usual capability and state, and it can also support support or support support? https://codereview.chromium.org/2842103002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right): https://codereview.chromium.org/2842103002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:406: // Merge any present |m_settings| members into |settings|. m_settings -> settings_
https://codereview.chromium.org/2842103002/diff/20001/media/capture/video/and... File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java (right): https://codereview.chromium.org/2842103002/diff/20001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:536: // Auto Exposure is the usual capability and state, and it can also support support or On 2017/04/28 23:30:19, Reilly Grant wrote: > support support? Done. https://codereview.chromium.org/2842103002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right): https://codereview.chromium.org/2842103002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:406: // Merge any present |m_settings| members into |settings|. On 2017/04/28 23:30:19, Reilly Grant wrote: > m_settings -> settings_ Done.
The CQ bit was checked by mcasas@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org Link to the patchset: https://codereview.chromium.org/2842103002/#ps40001 (title: "reillyg@ nits")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by mcasas@chromium.org
The CQ bit was checked by mcasas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by mcasas@chromium.org
The CQ bit was checked by mcasas@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org Link to the patchset: https://codereview.chromium.org/2842103002/#ps60001 (title: "reworded comment on supported exposure modes")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493426397024210,
"parent_rev": "180f998580b636654b08b415fa33f00c441dc3d2", "commit_rev":
"b6da435540cdb1774a04fcf9a45c98158caf299c"}
Message was sent while issue was closed.
Description was changed from ========== Image Capture: two small nits Android Auto Exposure is always available, make the implementation reflect that. In blink, don't fill dictionary entries with empty arrays. BUG=716636 ========== to ========== Image Capture: two small nits Android Auto Exposure is always available, make the implementation reflect that. In blink, don't fill dictionary entries with empty arrays. BUG=716636 Review-Url: https://codereview.chromium.org/2842103002 Cr-Commit-Position: refs/heads/master@{#468205} Committed: https://chromium.googlesource.com/chromium/src/+/b6da435540cdb1774a04fcf9a45c... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/b6da435540cdb1774a04fcf9a45c... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
