Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java

Issue 2842103002: Image Capture: two small nits (Closed)
Patch Set: reworded comment on supported exposure modes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
diff --git a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
index bf6f1bd93bee1d1f194f2edec835c3964ff75d7b..80b233fb1d213a4b3c86630ff6a0e2cb2f6a4b86 100644
--- a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
+++ b/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
@@ -533,13 +533,10 @@ public class VideoCaptureCamera
}
builder.setFocusMode(jniFocusMode);
- // Auto Exposure is the usual capability and state, unless AE is not available at all, which
- // is signalled by the absence of Metering Areas. Exposure Compensation can also support or
- // be locked, this is equivalent to AndroidMeteringMode.FIXED.
+ // Auto Exposure is understood to be supported always; besides that, only "locked"
+ // (equivalent to AndroidMeteringMode.FIXED) may be supported and/or configured.
ArrayList<Integer> jniExposureModes = new ArrayList<Integer>(2);
- if (parameters.getMaxNumMeteringAreas() > 0) {
- jniExposureModes.add(AndroidMeteringMode.CONTINUOUS);
- }
+ jniExposureModes.add(AndroidMeteringMode.CONTINUOUS);
if (parameters.isAutoExposureLockSupported()) {
jniExposureModes.add(AndroidMeteringMode.FIXED);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698