Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2842063003: Only start action mode if there is a selection (Closed)

Created:
3 years, 8 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Only start action mode if there is a selection It currently doesn't make sense to have an action mode without a selection. The main way to close the action mode is through |SELECTION_HANDLES_CLEARED| and that is not possible in this situation since there was no selection to begin with. BUG=715268 Review-Url: https://codereview.chromium.org/2836843006 Cr-Commit-Position: refs/heads/master@{#467186} (cherry picked from commit ae9712079d2b34e4a543a8f04de581a3b7bfd383) Review-Url: https://codereview.chromium.org/2842063003 . Cr-Commit-Position: refs/branch-heads/3071@{#216} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b601128af8413ee77c17735df8a2475118d5bce2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_OOO_until_Jul13
3 years, 8 months ago (2017-04-26 01:20:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b601128af8413ee77c17735df8a2475118d5bce2.

Powered by Google App Engine
This is Rietveld 408576698