content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java - Issue 2842063003: Only start action mode if there is a selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

Issue 2842063003: Only start action mode if there is a selection (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

index 987c433aa5fc0843b43244d18a2bd2bed2de423e..1b26475e537bb9f8be7551e17fbbab100e9fb7e5 100644

--- a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

+++ b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

@@ -222,7 +222,7 @@ public class SelectionPopupController extends ActionModeCallbackHelper {

public void showActionModeOrClearOnFailure() {

mPendingShowActionMode = false;

- if (!isActionModeSupported()) return;

+ if (!isActionModeSupported() || !mHasSelection) return;

// Just refresh the view if action mode already exists.

if (isActionModeValid()) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »