cocoa: fix a11y labeling & state on search icon

cocoa: fix a11y labeling & state on search icon

When this icon is present, it means that there is no current page info to show,
and so it has no tooltip and does not accept mouse presses. This change:

1) Makes the button always have its a11y label, even when it doesn't respond to
   mouse presses
2) Adds LocationBarDecoration::UpdateAccessibilityView to keep the a11y view's
   state synchronized with the decoration's state
3) Makes the Search icon actually reject mouse presses when they won't do
   anything

A side-effect of (3) is that clicking the Search icon now acts as though the
user had clicked the omnibox and focuses the omnibox, instead of doing nothing
at all with no feedback.

BUG=696232
Review-Url: https://codereview.chromium.org/2841963002
Cr-Commit-Position: refs/heads/master@{#467059}
Committed: https://chromium.googlesource.com/chromium/src/+/39063b7bab59e08486157cf48cd6b159c50a677c

[Elly Fong-Jones, 2017-04-25 18:05:23]

Description was changed from

==========
cocoa: fix a11y labeling & state on search icon

When this icon is present, it means that there is no current page info to show,
and so it has no tooltip and does not accept mouse presses. This change:

1) Makes the button always have its a11y label, even when it doesn't respond to
   mouse presses
2) Adds LocationBarDecoration::UpdateAccessibilityView to keep the a11y view's
   state synchronized with the decoration's state
3) Makes the Search icon actually reject mouse presses when they won't do
   anything

A side-effect of (3) is that clicking the Search icon now acts as though the
user had clicked the omnibox and focuses the omnibox, instead of doing nothing
at all with no feedback.

BUG=696232
==========

to

==========
cocoa: fix a11y labeling & state on search icon

When this icon is present, it means that there is no current page info to show,
and so it has no tooltip and does not accept mouse presses. This change:

1) Makes the button always have its a11y label, even when it doesn't respond to
   mouse presses
2) Adds LocationBarDecoration::UpdateAccessibilityView to keep the a11y view's
   state synchronized with the decoration's state
3) Makes the Search icon actually reject mouse presses when they won't do
   anything

A side-effect of (3) is that clicking the Search icon now acts as though the
user had clicked the omnibox and focuses the omnibox, instead of doing nothing
at all with no feedback.

BUG=696232
==========

[Elly Fong-Jones, 2017-04-25 18:05:23]

ellyjones@chromium.org changed reviewers:
+ mark@chromium.org

[Elly Fong-Jones, 2017-04-25 18:05:30]

mark: ptal? :)

[Mark Mentovai, 2017-04-25 18:08:52]

I think the stated side effect of (3) is positive. LGTM.

[Elly Fong-Jones, 2017-04-25 18:09:21]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2017-04-25 18:09:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 18:36:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493143761857670, "parent_rev":
"d80c41e37b7570607f6f877961f487f7f24ae12e", "commit_rev":
"39063b7bab59e08486157cf48cd6b159c50a677c"}

[commit-bot: I haz the power, 2017-04-25 18:37:07]

Description was changed from

==========
cocoa: fix a11y labeling & state on search icon

When this icon is present, it means that there is no current page info to show,
and so it has no tooltip and does not accept mouse presses. This change:

1) Makes the button always have its a11y label, even when it doesn't respond to
   mouse presses
2) Adds LocationBarDecoration::UpdateAccessibilityView to keep the a11y view's
   state synchronized with the decoration's state
3) Makes the Search icon actually reject mouse presses when they won't do
   anything

A side-effect of (3) is that clicking the Search icon now acts as though the
user had clicked the omnibox and focuses the omnibox, instead of doing nothing
at all with no feedback.

BUG=696232
==========

to

==========
cocoa: fix a11y labeling & state on search icon

When this icon is present, it means that there is no current page info to show,
and so it has no tooltip and does not accept mouse presses. This change:

1) Makes the button always have its a11y label, even when it doesn't respond to
   mouse presses
2) Adds LocationBarDecoration::UpdateAccessibilityView to keep the a11y view's
   state synchronized with the decoration's state
3) Makes the Search icon actually reject mouse presses when they won't do
   anything

A side-effect of (3) is that clicking the Search icon now acts as though the
user had clicked the omnibox and focuses the omnibox, instead of doing nothing
at all with no feedback.

BUG=696232

Review-Url: https://codereview.chromium.org/2841963002
Cr-Commit-Position: refs/heads/master@{#467059}
Committed:
https://chromium.googlesource.com/chromium/src/+/39063b7bab59e08486157cf48cd6...
==========

[commit-bot: I haz the power, 2017-04-25 18:37:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/39063b7bab59e08486157cf48cd6...