Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3056)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 2841963002: cocoa: fix a11y labeling & state on search icon (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
index 7dbe0c7618142e7040896e823c1a5b7203895d92..4b59a6a66a91374d3070697eb15adbd6afd3e568 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
@@ -334,7 +334,7 @@ new ManagePasswordsDecoration(command_updater, this)),
// change, here.
std::vector<LocationBarDecoration*> decorations = GetDecorations();
for (auto* decoration : decorations)
- UpdateAccessibilityViewPosition(decoration);
+ UpdateAccessibilityView(decoration);
[field_ updateMouseTracking];
[field_ resetFieldEditorFrameIfNeeded];
[field_ setNeedsDisplay:YES];
@@ -738,7 +738,7 @@ new ManagePasswordsDecoration(command_updater, this)),
level == security_state::EV_SECURE;
}
-void LocationBarViewMac::UpdateAccessibilityViewPosition(
+void LocationBarViewMac::UpdateAccessibilityView(
LocationBarDecoration* decoration) {
if (!decoration->IsVisible())
return;
@@ -746,6 +746,7 @@ new ManagePasswordsDecoration(command_updater, this)),
[[field_ cell] frameForDecoration:decoration inFrame:[field_ frame]];
[decoration->GetAccessibilityView() setFrame:r];
[decoration->GetAccessibilityView() setNeedsDisplayInRect:r];
+ decoration->UpdateAccessibilityView();
}
std::vector<LocationBarDecoration*> LocationBarViewMac::GetDecorations() {

Powered by Google App Engine
This is Rietveld 408576698