Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2841763002: Rename ScrollType helper and combine some redundant checks. (Closed)

Created:
3 years, 8 months ago by skobes
Modified:
3 years, 8 months ago
Reviewers:
bokan, pdr.
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org, dshwang, kinuko+watch, blink-reviews-paint_chromium.org, aelias_OOO_until_Jul13
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ScrollType helper and combine some redundant checks. BUG=606395 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2841763002 Cr-Commit-Position: refs/heads/master@{#467191} Committed: https://chromium.googlesource.com/chromium/src/+/4eeacf4f4fa0bbfffb04f81d113875f044ac5141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollTypes.h View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
skobes
3 years, 8 months ago (2017-04-25 20:34:21 UTC) #7
bokan
lgtm
3 years, 8 months ago (2017-04-25 21:49:50 UTC) #8
pdr.
On 2017/04/25 at 21:49:50, bokan wrote: > lgtm lgtm 2
3 years, 8 months ago (2017-04-26 00:01:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841763002/1
3 years, 8 months ago (2017-04-26 01:05:16 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 01:10:33 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4eeacf4f4fa0bbfffb04f81d1138...

Powered by Google App Engine
This is Rietveld 408576698