PPC/s390: [sim] Consistent support for C calls with up to 9 args

PPC/s390: [sim] Consistent support for C calls with up to 9 args

Port 3337ccccd97bf226d81124206c16eafc216f0ae8

Original Commit Message:

    Consistently support calls to host-C-linkage functions with up to 9 arguments
    from the simulator, and check that these limits aren't exceeded accidentally.

R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=v8:6281
LOG=N

Review-Url: https://codereview.chromium.org/2841693003
Cr-Commit-Position: refs/heads/master@{#44858}
Committed: https://chromium.googlesource.com/v8/v8/+/a489abe846bb071b880c854290356af0cc521baf

[JaideepBajwa, 2017-04-25 03:27:33]

ptal

[john.yan, 2017-04-25 05:09:41]

lgtm

[jgruber, 2017-04-25 05:43:36]

lgtm

https://codereview.chromium.org/2841693003/diff/1/src/ppc/simulator-ppc.cc
File src/ppc/simulator-ppc.cc (right):

https://codereview.chromium.org/2841693003/diff/1/src/ppc/simulator-ppc.cc#ne...
src/ppc/simulator-ppc.cc:1347: for (int i = 0; i < kArgCount - 1; i++) {
Nit: kRegisterArgCount = 8; i < kRegisterArgCount; STATIC_ASSERT(kArgCount ==
kRegisterArgCount + 1);

https://codereview.chromium.org/2841693003/diff/1/src/s390/simulator-s390.cc
File src/s390/simulator-s390.cc (right):

https://codereview.chromium.org/2841693003/diff/1/src/s390/simulator-s390.cc#...
src/s390/simulator-s390.cc:1989: for (int i = 0; i < 5; i++) {
Nit: kRegisterArgCount = 5;

[JaideepBajwa, 2017-04-25 13:41:17]

On 2017/04/25 05:43:36, jgruber wrote:
> lgtm
> 
> https://codereview.chromium.org/2841693003/diff/1/src/ppc/simulator-ppc.cc
> File src/ppc/simulator-ppc.cc (right):
> 
>
https://codereview.chromium.org/2841693003/diff/1/src/ppc/simulator-ppc.cc#ne...
> src/ppc/simulator-ppc.cc:1347: for (int i = 0; i < kArgCount - 1; i++) {
> Nit: kRegisterArgCount = 8; i < kRegisterArgCount; STATIC_ASSERT(kArgCount ==
> kRegisterArgCount + 1);
> 
> https://codereview.chromium.org/2841693003/diff/1/src/s390/simulator-s390.cc
> File src/s390/simulator-s390.cc (right):
> 
>
https://codereview.chromium.org/2841693003/diff/1/src/s390/simulator-s390.cc#...
> src/s390/simulator-s390.cc:1989: for (int i = 0; i < 5; i++) {
> Nit: kRegisterArgCount = 5;

Done, thanks.

[JaideepBajwa, 2017-04-25 13:41:24]

The CQ bit was checked by bjaideep@ca.ibm.com

[JaideepBajwa, 2017-04-25 13:41:25]

The patchset sent to the CQ was uploaded after l-g-t-m from jyan@ca.ibm.com,
jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2841693003/#ps20001
(title: "rebased and addressed comments")

[commit-bot: I haz the power, 2017-04-25 13:41:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 14:17:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493127684415760,
"parent_rev": "95d53ffee15e73a6423284bfedb1403c12633d47", "commit_rev":
"5bfc35fa1daacaf18e80fa607f061153bf3361e5"}

[commit-bot: I haz the power, 2017-04-25 14:17:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493127684415760,
"parent_rev": "28930128ce24c899676b0e15e85095574f7e04c3", "commit_rev":
"a489abe846bb071b880c854290356af0cc521baf"}

[commit-bot: I haz the power, 2017-04-25 14:17:41]

Description was changed from

==========
PPC/s390: [sim] Consistent support for C calls with up to 9 args

Port 3337ccccd97bf226d81124206c16eafc216f0ae8

Original Commit Message:

    Consistently support calls to host-C-linkage functions with up to 9
arguments
    from the simulator, and check that these limits aren't exceeded
accidentally.

R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com
BUG=v8:6281
LOG=N
==========

to

==========
PPC/s390: [sim] Consistent support for C calls with up to 9 args

Port 3337ccccd97bf226d81124206c16eafc216f0ae8

Original Commit Message:

    Consistently support calls to host-C-linkage functions with up to 9
arguments
    from the simulator, and check that these limits aren't exceeded
accidentally.

R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com
BUG=v8:6281
LOG=N

Review-Url: https://codereview.chromium.org/2841693003
Cr-Commit-Position: refs/heads/master@{#44858}
Committed:
https://chromium.googlesource.com/v8/v8/+/a489abe846bb071b880c854290356af0cc5...
==========

[commit-bot: I haz the power, 2017-04-25 14:17:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a489abe846bb071b880c854290356af0cc5...