src/s390/macro-assembler-s390.cc - Issue 2841693003: PPC/s390: [sim] Consistent support for C calls with up to 9 args

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/s390/macro-assembler-s390.cc

Issue 2841693003: PPC/s390: [sim] Consistent support for C calls with up to 9 args (Closed)

Patch Set: rebased and addressed comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/s390/macro-assembler-s390.cc

diff --git a/src/s390/macro-assembler-s390.cc b/src/s390/macro-assembler-s390.cc

index bd6f962a8487895241f51da0867596e2cced3fe8..6671a140a58c5400ac8ccd194d46972990bdbef8 100644

--- a/src/s390/macro-assembler-s390.cc

+++ b/src/s390/macro-assembler-s390.cc

@@ -2712,6 +2712,7 @@ void MacroAssembler::CallCFunction(Register function, int num_arguments) {

void MacroAssembler::CallCFunctionHelper(Register function,

int num_reg_arguments,

int num_double_arguments) {

+ DCHECK_LE(num_reg_arguments + num_double_arguments, kMaxCParameters);

DCHECK(has_frame());

// Just call directly. The function called cannot cause a GC, or

« no previous file with comments | « src/ppc/simulator-ppc.cc ('k') | src/s390/simulator-s390.cc » ('j') | no next file with comments »