When a new Payments address is created from the editor, use it as the chosen address

When a new Payments address is created from the editor, use it as the chosen address

BUG=714613
Review-Url: https://codereview.chromium.org/2841643002
Cr-Commit-Position: refs/heads/master@{#467060}
Committed: https://chromium.googlesource.com/chromium/src/+/f9904eaaed1d0b970830289c7004be133549f46f

[MAD, 2017-04-24 17:10:45]

mad@chromium.org changed reviewers:
+ mathp@google.com

[Mathieu, 2017-04-24 19:43:42]

Description was changed from

==========
When a new Payments address is created from the editor, use it as the chosen
address

BUG=714613
==========

to

==========
When a new Payments address is created from the editor, use it as the chosen
address

BUG=714613
==========

[Mathieu, 2017-04-24 19:43:42]

mathp@chromium.org changed reviewers:
+ mathp@chromium.org
- mathp@google.com

[Mathieu, 2017-04-24 20:05:19]

Thanks, just a request for test let me know if it makes sense

https://codereview.chromium.org/2841643002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_dialog_view.h (right):

https://codereview.chromium.org/2841643002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_dialog_view.h:114: //
|on_added| is called when a new profile card was added (the reference is
*new profile was added

https://codereview.chromium.org/2841643002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
(right):

https://codereview.chromium.org/2841643002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h:29:
// Does not take ownership of the arguments, which should outlive this object.
it does take ownership of the callbacks :)

https://codereview.chromium.org/2841643002/diff/20001/chrome/browser/ui/views...
File
chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
(right):

https://codereview.chromium.org/2841643002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc:211:
EnteringValidDataWithDefaultCountry) {
Could we have a test similar to
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/payments/credit_...

Where there is an invalid address available (according to my current big hack
[1], an invalid address is one that is missing the zip code), we select it, fix
it in the editor and verify that it is now selected?

[1]
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/payments/profile...

[MAD, 2017-04-25 14:23:50]

How about this now?

Thanks!

BYE
MAD...

https://codereview.chromium.org/2841643002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_dialog_view.h (right):

https://codereview.chromium.org/2841643002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_dialog_view.h:114: //
|on_added| is called when a new profile card was added (the reference is
On 2017/04/24 20:05:19, Mathieu wrote:
> *new profile was added

Done.

https://codereview.chromium.org/2841643002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
(right):

https://codereview.chromium.org/2841643002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h:29:
// Does not take ownership of the arguments, which should outlive this object.
On 2017/04/24 20:05:19, Mathieu wrote:
> it does take ownership of the callbacks :)

Done.

https://codereview.chromium.org/2841643002/diff/20001/chrome/browser/ui/views...
File
chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
(right):

https://codereview.chromium.org/2841643002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc:211:
EnteringValidDataWithDefaultCountry) {
On 2017/04/24 20:05:19, Mathieu wrote:
> Could we have a test similar to
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/payments/credit_...
> 
> Where there is an invalid address available (according to my current big hack
> [1], an invalid address is one that is missing the zip code), we select it,
fix
> it in the editor and verify that it is now selected?
> 
> [1]
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/payments/profile...

As discussed, will do this in another CL.

[Mathieu, 2017-04-25 14:29:51]

lgtm

[MAD, 2017-04-25 14:31:46]

Patchset #4 (id:60001) has been deleted

[MAD, 2017-04-25 14:32:39]

mad@chromium.org changed reviewers:
+ rouslan@chromium.org

[MAD, 2017-04-25 14:32:40]

Thanks Mathieu, +Rouslan for OWNERs approval.

BYE
MAD

[MAD, 2017-04-25 14:33:04]

The CQ bit was checked by mad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 14:33:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mathieu, 2017-04-25 14:33:37]

On 2017/04/25 14:32:40, MAD wrote:
> Thanks Mathieu, +Rouslan for OWNERs approval.
> 
> BYE
> MAD

Should be good to go with just my approval

[commit-bot: I haz the power, 2017-04-25 14:37:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 14:37:04]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2017-04-25 14:37:41]

lgtm

[MAD, 2017-04-25 15:08:43]

Weird, git cl upload was complaining that I was missing an OWNER...

Can you double check I properly resolved the conflicts, especially in the
structure change of the profile list view controller?

Thanks!

BYE
MAD

[MAD, 2017-04-25 15:08:57]

The CQ bit was checked by mad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 15:09:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-04-25 15:10:54]

My Chrome extension is telling me all required owners have approved this change.
profile_list_view_controller.cc looks good.

https://chrome.google.com/webstore/detail/chromite-butler/bhcnanendmgjjeghama...

[MAD, 2017-04-25 15:18:34]

mad@chromium.org changed reviewers:
- rouslan@chromium.org

[commit-bot: I haz the power, 2017-04-25 15:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 15:20:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[MAD, 2017-04-25 15:21:04]

The CQ bit was checked by mad@chromium.org

[MAD, 2017-04-25 15:21:04]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2841643002/#ps100001
(title: "Small goof fix")

[commit-bot: I haz the power, 2017-04-25 15:21:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 15:32:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 15:32:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[MAD, 2017-04-25 16:01:37]

The CQ bit was checked by mad@chromium.org

[MAD, 2017-04-25 16:01:38]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2841643002/#ps120001
(title: "Non windows compile error fix")

[commit-bot: I haz the power, 2017-04-25 16:02:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 16:26:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 16:26:59]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[MAD, 2017-04-25 17:41:16]

The CQ bit was checked by mad@chromium.org

[MAD, 2017-04-25 17:41:17]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2841643002/#ps140001
(title: "And yet another small goof fix... :-(")

[commit-bot: I haz the power, 2017-04-25 17:41:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 18:39:15]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493142076674590,
"parent_rev": "39063b7bab59e08486157cf48cd6b159c50a677c", "commit_rev":
"f9904eaaed1d0b970830289c7004be133549f46f"}

[commit-bot: I haz the power, 2017-04-25 18:39:25]

Description was changed from

==========
When a new Payments address is created from the editor, use it as the chosen
address

BUG=714613
==========

to

==========
When a new Payments address is created from the editor, use it as the chosen
address

BUG=714613

Review-Url: https://codereview.chromium.org/2841643002
Cr-Commit-Position: refs/heads/master@{#467060}
Committed:
https://chromium.googlesource.com/chromium/src/+/f9904eaaed1d0b970830289c7004...
==========

[commit-bot: I haz the power, 2017-04-25 18:39:26]

Committed patchset #7 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/f9904eaaed1d0b970830289c7004...