Add a new test for incomplete payment shipping address

Add a new test for incomplete payment shipping address

BUG=None

Review-Url: https://codereview.chromium.org/2838923002
Cr-Commit-Position: refs/heads/master@{#467092}
Committed: https://chromium.googlesource.com/chromium/src/+/3007e36bd4c69727b84ebb459a77cd4cab906f7d

[MAD, 2017-04-25 17:52:29]

mad@chromium.org changed reviewers:
+ mathp@chromium.org

[MAD, 2017-04-25 17:52:29]

As requested. Is this what you meant?

Thanks!

BYE
MAD...

[Mathieu, 2017-04-25 17:56:28]

Amazing, thanks! lgtm with nit

https://codereview.chromium.org/2838923002/diff/1/chrome/browser/ui/views/pay...
File
chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
(right):

https://codereview.chromium.org/2838923002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc:445:
ExpectExistingRequiredFields(nullptr);
nit: /*unset_types=*/nullptr

[MAD, 2017-04-25 18:03:17]

Thanks, CQ'ing...

https://codereview.chromium.org/2838923002/diff/1/chrome/browser/ui/views/pay...
File
chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
(right):

https://codereview.chromium.org/2838923002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc:445:
ExpectExistingRequiredFields(nullptr);
On 2017/04/25 17:56:28, Mathieu wrote:
> nit: /*unset_types=*/nullptr

Done.

[MAD, 2017-04-25 18:03:23]

The CQ bit was checked by mad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 18:04:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 19:04:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 19:04:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[MAD, 2017-04-25 19:42:00]

The CQ bit was checked by mad@chromium.org

[MAD, 2017-04-25 19:42:01]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2838923002/#ps40001
(title: "Now use PaymentRequestBrowserTestBase::AddAutofillProfile")

[commit-bot: I haz the power, 2017-04-25 19:42:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 20:23:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493149320544270,
"parent_rev": "758540e55198236edc0a417b7dd69e60a3ceedac", "commit_rev":
"3007e36bd4c69727b84ebb459a77cd4cab906f7d"}

[commit-bot: I haz the power, 2017-04-25 20:24:29]

Description was changed from

==========
Add a new test for incomplete payment shipping address

BUG=None
==========

to

==========
Add a new test for incomplete payment shipping address

BUG=None

Review-Url: https://codereview.chromium.org/2838923002
Cr-Commit-Position: refs/heads/master@{#467092}
Committed:
https://chromium.googlesource.com/chromium/src/+/3007e36bd4c69727b84ebb459a77...
==========

[commit-bot: I haz the power, 2017-04-25 20:24:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3007e36bd4c69727b84ebb459a77...