Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2841393002: DOM: Remove blink::NodeFilterCondition. (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DOM: Remove blink::NodeFilterCondition. This interface isn't helpful. BUG=591919 Review-Url: https://codereview.chromium.org/2841393002 Cr-Commit-Position: refs/heads/master@{#467622} Committed: https://chromium.googlesource.com/chromium/src/+/659c8284c33baf483121f1248d5aaa989d5dabe0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -54 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.h View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/dom/NodeFilterCondition.h View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
bashi@, would you review this please? A trivial cleanup.
3 years, 7 months ago (2017-04-27 07:56:52 UTC) #4
bashi
lgtm
3 years, 7 months ago (2017-04-27 08:07:31 UTC) #5
haraken
LGTM
3 years, 7 months ago (2017-04-27 08:21:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841393002/1
3 years, 7 months ago (2017-04-27 08:40:40 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 08:45:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/659c8284c33baf483121f1248d5a...

Powered by Google App Engine
This is Rietveld 408576698