Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.h

Issue 2841393002: DOM: Remove blink::NodeFilterCondition. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.h b/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.h
index c2f16752a547b8f7cc6ea6d078ba82d8743e92ef..f40f8cf722cbb46477a4a9465afd1119a4df730b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.h
@@ -33,7 +33,6 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "bindings/core/v8/TraceWrapperV8Reference.h"
-#include "core/dom/NodeFilterCondition.h"
#include "platform/heap/Handle.h"
#include "v8/include/v8.h"
@@ -48,8 +47,9 @@ class ScriptState;
// is referenced by a NodeIterator/TreeWalker.
//
// Binding generator should generate this code. See crbug.com/630986.
-class V8NodeFilterCondition final : public NodeFilterCondition,
- public TraceWrapperBase {
+class V8NodeFilterCondition final
+ : public GarbageCollectedFinalized<V8NodeFilterCondition>,
+ public TraceWrapperBase {
public:
static V8NodeFilterCondition* CreateOrNull(v8::Local<v8::Value> filter,
ScriptState* script_state) {
@@ -57,10 +57,11 @@ class V8NodeFilterCondition final : public NodeFilterCondition,
: new V8NodeFilterCondition(filter, script_state);
}
- ~V8NodeFilterCondition() override;
+ ~V8NodeFilterCondition();
+ DEFINE_INLINE_VIRTUAL_TRACE() {}
DECLARE_TRACE_WRAPPERS();
- unsigned acceptNode(Node*, ExceptionState&) const override;
+ unsigned acceptNode(Node*, ExceptionState&) const;
v8::Local<v8::Value> Callback(v8::Isolate* isolate) const {
return filter_.NewLocal(isolate);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698