Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2841203003: Remove unnecessary crash keys. (Closed)

Created:
3 years, 7 months ago by nasko
Modified:
3 years, 7 months ago
Reviewers:
Robert Sesek, jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, sadrul, lcwu+watch_chromium.org, nasko+codewatch_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, alokp+watch_chromium.org, kalyank, creis+watch_chromium.org, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary crash keys. Since bug 630103 was fixed, these crash keys are no longer necessary. BUG=630103 Review-Url: https://codereview.chromium.org/2841203003 Cr-Commit-Position: refs/heads/master@{#468017} Committed: https://chromium.googlesource.com/chromium/src/+/e17ef94d67dfe018efe33b4a6c95337ca193e388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M android_webview/common/crash_reporter/crash_keys.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_win.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chromecast/crash/cast_crash_keys.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
nasko
Hey rsesek@, Can you review this CL for me? It removes some obsolete crash keys. ...
3 years, 7 months ago (2017-04-27 17:08:43 UTC) #2
Robert Sesek
lgtm
3 years, 7 months ago (2017-04-27 17:32:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841203003/1
3 years, 7 months ago (2017-04-27 17:36:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/422293)
3 years, 7 months ago (2017-04-27 17:47:50 UTC) #7
nasko
Hey John, Can you stamp this CL for me? I thought rsesek@ is an OWNER ...
3 years, 7 months ago (2017-04-27 18:04:07 UTC) #9
jam
lgtm
3 years, 7 months ago (2017-04-28 15:42:27 UTC) #10
jam
On 2017/04/28 15:42:27, jam wrote: > lgtm seems like we should have * as owners ...
3 years, 7 months ago (2017-04-28 15:42:58 UTC) #11
Robert Sesek
On 2017/04/28 15:42:58, jam wrote: > On 2017/04/28 15:42:27, jam wrote: > > lgtm > ...
3 years, 7 months ago (2017-04-28 16:01:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841203003/1
3 years, 7 months ago (2017-04-28 16:03:23 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 16:08:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e17ef94d67dfe018efe33b4a6c95...

Powered by Google App Engine
This is Rietveld 408576698