Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2841203003: Remove unnecessary crash keys. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « android_webview/common/crash_reporter/crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <windows.h> 9 #include <windows.h>
10 10
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 // Temporary for https://crbug.com/626802. 176 // Temporary for https://crbug.com/626802.
177 {"newframe_routing_id", kSmallSize}, 177 {"newframe_routing_id", kSmallSize},
178 {"newframe_proxy_id", kSmallSize}, 178 {"newframe_proxy_id", kSmallSize},
179 {"newframe_opener_id", kSmallSize}, 179 {"newframe_opener_id", kSmallSize},
180 {"newframe_parent_id", kSmallSize}, 180 {"newframe_parent_id", kSmallSize},
181 {"newframe_widget_id", kSmallSize}, 181 {"newframe_widget_id", kSmallSize},
182 {"newframe_widget_hidden", kSmallSize}, 182 {"newframe_widget_hidden", kSmallSize},
183 {"newframe_replicated_origin", kSmallSize}, 183 {"newframe_replicated_origin", kSmallSize},
184 {"newframe_oopifs_possible", kSmallSize}, 184 {"newframe_oopifs_possible", kSmallSize},
185 185
186 // Temporary for https://crbug.com/630103.
187 {"origin_mismatch_url", crash_keys::kLargeSize},
188 {"origin_mismatch_origin", crash_keys::kMediumSize},
189 {"origin_mismatch_transition", crash_keys::kSmallSize},
190 {"origin_mismatch_redirects", crash_keys::kSmallSize},
191 {"origin_mismatch_same_page", crash_keys::kSmallSize},
192
193 // Temporary for https://crbug.com/612711. 186 // Temporary for https://crbug.com/612711.
194 {"aci_wrong_sp_extension_id", kSmallSize}, 187 {"aci_wrong_sp_extension_id", kSmallSize},
195 188
196 // Temporary for http://crbug.com/621730 189 // Temporary for http://crbug.com/621730
197 {"postmessage_src_origin", kMediumSize}, 190 {"postmessage_src_origin", kMediumSize},
198 {"postmessage_dst_origin", kMediumSize}, 191 {"postmessage_dst_origin", kMediumSize},
199 {"postmessage_dst_url", kLargeSize}, 192 {"postmessage_dst_url", kLargeSize},
200 {"postmessage_script_info", kLargeSize}, 193 {"postmessage_script_info", kLargeSize},
201 194
202 // Temporary for https://crbug.com/668633. 195 // Temporary for https://crbug.com/668633.
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 425
433 return base::RandDouble() < probability; 426 return base::RandDouble() < probability;
434 } 427 }
435 428
436 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 429 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
437 const std::string& process_type) { 430 const std::string& process_type) {
438 // This is not used by Crashpad (at least on Windows). 431 // This is not used by Crashpad (at least on Windows).
439 NOTREACHED(); 432 NOTREACHED();
440 return true; 433 return true;
441 } 434 }
OLDNEW
« no previous file with comments | « android_webview/common/crash_reporter/crash_keys.cc ('k') | chrome/common/crash_keys.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698