Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2841123002: [DevTools] Listen to RenderFrameHostChanged after crash with PlzNavigate (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Listen to RenderFrameHostChanged after crash with PlzNavigate During cross-process navigation after crash, RenderFrameHostChanged is called early with new RFH, and the old one goes away. This happens before ReadyToCommitNavigation and we should change current RFH to avoid accessing the stale one. BUG=711451 Review-Url: https://codereview.chromium.org/2841123002 Cr-Commit-Position: refs/heads/master@{#467816} Committed: https://chromium.googlesource.com/chromium/src/+/ea1226095c8fe84ea661a5fed649004686284f32

Patch Set 1 #

Patch Set 2 : windows fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 1 chunk +19 lines, -0 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
dgozman
Could you please take a look?
3 years, 8 months ago (2017-04-26 19:36:51 UTC) #7
pfeldman
lgtm
3 years, 7 months ago (2017-04-27 21:46:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841123002/20001
3 years, 7 months ago (2017-04-27 22:39:01 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 01:51:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ea1226095c8fe84ea661a5fed649...

Powered by Google App Engine
This is Rietveld 408576698