content/browser/devtools/render_frame_devtools_agent_host.cc - Issue 2841123002: [DevTools] Listen to RenderFrameHostChanged after crash with PlzNavigate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2841123002: [DevTools] Listen to RenderFrameHostChanged after crash with PlzNavigate (Closed)

Patch Set: windows fix Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/render_frame_devtools_agent_host.cc

diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc

index 204903c3a124cc408b51725a2d902665b6746e0c..1a6be758941cbf54069fae1b0f0be90c8bf61527 100644

--- a/content/browser/devtools/render_frame_devtools_agent_host.cc

+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc

@@ -762,7 +762,7 @@ void RenderFrameDevToolsAgentHost::RenderFrameHostChanged(

if (session())

protocol::TargetHandler::FromSession(session())->UpdateFrames();

- if (IsBrowserSideNavigationEnabled())

+ if (IsBrowserSideNavigationEnabled() && !current_frame_crashed_)

return;

DCHECK(!pending_ || pending_->host() != old_host);

« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_browsertest.cc ('k') | no next file » | no next file with comments »