Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2841113002: Add convenience methods for PLSA visible client dimensions. (Closed)

Created:
3 years, 8 months ago by szager1
Modified:
3 years, 7 months ago
Reviewers:
skobes
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[RootLayerScrolls] Add convenience methods for PLSA visible client size. This anticipates when the size of the main frame's root layer is based on the main frame's layout size. BUG=701575 R=skobes@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2841113002 Cr-Commit-Position: refs/heads/master@{#468062} Committed: https://chromium.googlesource.com/chromium/src/+/9309126a1a26b15343a2db4e2a5358dcaa9bd9f8

Patch Set 1 #

Patch Set 2 : Use FrameView's layout size for visible client size. #

Patch Set 3 : Test rebaselines #

Patch Set 4 : Revert inadvertent snapping #

Patch Set 5 : cleanup #

Total comments: 2

Patch Set 6 : Exclude scrollbars from client size #

Patch Set 7 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -11 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 2 3 4 5 6 chunks +35 lines, -11 lines 0 comments Download

Messages

Total messages: 32 (21 generated)
szager1
3 years, 7 months ago (2017-04-27 14:16:05 UTC) #12
skobes
Why is custom-scrollbar-display-expected.png added here? Is it different from the non-virtual baseline? https://codereview.chromium.org/2841113002/diff/80001/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h File third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h ...
3 years, 7 months ago (2017-04-27 23:22:47 UTC) #17
szager1
On 2017/04/27 23:22:47, skobes wrote: > Why is custom-scrollbar-display-expected.png added here? Is it different from ...
3 years, 7 months ago (2017-04-28 11:01:28 UTC) #18
szager1
https://codereview.chromium.org/2841113002/diff/80001/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h File third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h (right): https://codereview.chromium.org/2841113002/diff/80001/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h#newcode300 third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h:300: LayoutSize ClientSize() const; On 2017/04/27 23:22:47, skobes wrote: > ...
3 years, 7 months ago (2017-04-28 11:04:53 UTC) #19
szager1
On 2017/04/28 11:01:28, szager1 wrote: > On 2017/04/27 23:22:47, skobes wrote: > > Why is ...
3 years, 7 months ago (2017-04-28 15:04:05 UTC) #22
skobes
On 2017/04/28 11:04:53, szager1 wrote: > On 2017/04/27 23:22:47, skobes wrote: > > Isn't this ...
3 years, 7 months ago (2017-04-28 15:25:11 UTC) #23
szager1
On 2017/04/28 15:25:11, skobes wrote: > On 2017/04/28 11:04:53, szager1 wrote: > > On 2017/04/27 ...
3 years, 7 months ago (2017-04-28 15:52:47 UTC) #24
skobes
lgtm w/ comment saying it's temporary until VisibleContentRect is fixed
3 years, 7 months ago (2017-04-28 15:56:37 UTC) #25
szager1
On 2017/04/28 15:56:37, skobes wrote: > lgtm w/ comment saying it's temporary until VisibleContentRect is ...
3 years, 7 months ago (2017-04-28 16:06:46 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841113002/120001
3 years, 7 months ago (2017-04-28 16:07:29 UTC) #29
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 18:16:39 UTC) #32
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/9309126a1a26b15343a2db4e2a53...

Powered by Google App Engine
This is Rietveld 408576698