Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2841113002: Add convenience methods for PLSA visible client dimensions. (Closed)
Patch Set: comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
index a00b42bb565f10b645cde6b8b1ffc33bbdfc8a6b..c9683ae60dde99f05576f779e594b990bad25c79 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
@@ -297,6 +297,16 @@ class CORE_EXPORT PaintLayerScrollableArea final
CompositorAnimationHost* GetCompositorAnimationHost() const override;
CompositorAnimationTimeline* GetCompositorAnimationTimeline() const override;
+ // These are temporary convenience methods. They delegate to Box() methods,
+ // which will be up-to-date when UpdateAfterLayout runs. By contrast,
+ // VisibleContentRect() is based on layer_.Size(), which isn't updated
+ // until later, when UpdateLayerPosition runs. A future patch will cause
+ // layer_.Size() to be updated effectively simultaneously with Box()
+ // sizing. When that lands, these methods should be removed in favor of
+ // using VisibleContentRect() and/or layer_.Size() everywhere.
+ LayoutSize ClientSize() const;
+ IntSize PixelSnappedClientSize() const;
+
void VisibleSizeChanged();
// FIXME: We shouldn't allow access to m_overflowRect outside this class.
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698