Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2841033002: Avoid repeating frame info calculation in Java layer (Closed)

Created:
3 years, 8 months ago by Jinsuk Kim
Modified:
3 years, 7 months ago
Reviewers:
boliu
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, agrieve+watch_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid repeating frame info calculation in Java layer Native layer is already calculating some frame info about top control (position + update flag). This CL passes the values to Java layer so that it won't repeat those operations again. Review-Url: https://codereview.chromium.org/2841033002 Cr-Commit-Position: refs/heads/master@{#467871} Committed: https://chromium.googlesource.com/chromium/src/+/61654002540ff418d34c869a745aadd4d6e71c59

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Jinsuk Kim
3 years, 7 months ago (2017-04-27 05:12:54 UTC) #3
boliu
lgtm % comment https://codereview.chromium.org/2841033002/diff/1/content/browser/android/content_view_core_impl.h File content/browser/android/content_view_core_impl.h (right): https://codereview.chromium.org/2841033002/diff/1/content/browser/android/content_view_core_impl.h#newcode255 content/browser/android/content_view_core_impl.h:255: // All sizes and offsets are ...
3 years, 7 months ago (2017-04-27 17:30:50 UTC) #4
Jinsuk Kim
https://codereview.chromium.org/2841033002/diff/1/content/browser/android/content_view_core_impl.h File content/browser/android/content_view_core_impl.h (right): https://codereview.chromium.org/2841033002/diff/1/content/browser/android/content_view_core_impl.h#newcode255 content/browser/android/content_view_core_impl.h:255: // All sizes and offsets are in CSS pixels ...
3 years, 7 months ago (2017-04-27 23:47:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841033002/20001
3 years, 7 months ago (2017-04-28 02:14:09 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 03:27:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/61654002540ff418d34c869a745a...

Powered by Google App Engine
This is Rietveld 408576698