Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: content/browser/android/content_view_core_impl.h

Issue 2841033002: Avoid repeating frame info calculation in Java layer (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 5 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
6 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 6 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 // Otherwise, item's "checked" flag selects it. 245 // Otherwise, item's "checked" flag selects it.
246 void ShowSelectPopupMenu(RenderFrameHost* frame, 246 void ShowSelectPopupMenu(RenderFrameHost* frame,
247 const gfx::Rect& bounds, 247 const gfx::Rect& bounds,
248 const std::vector<MenuItem>& items, 248 const std::vector<MenuItem>& items,
249 int selected_item, 249 int selected_item,
250 bool multiple, 250 bool multiple,
251 bool right_aligned); 251 bool right_aligned);
252 // Hides a visible popup menu. 252 // Hides a visible popup menu.
253 void HideSelectPopupMenu(); 253 void HideSelectPopupMenu();
254 254
255 // All sizes and offsets are in CSS pixels as cached by the renderer. 255 // All sizes and offsets are in CSS pixels as cached by the renderer.
boliu 2017/04/27 17:30:50 update comment
Jinsuk Kim 2017/04/27 23:47:03 Done.
256 void UpdateFrameInfo(const gfx::Vector2dF& scroll_offset, 256 void UpdateFrameInfo(const gfx::Vector2dF& scroll_offset,
257 float page_scale_factor, 257 float page_scale_factor,
258 const gfx::Vector2dF& page_scale_factor_limits, 258 const gfx::Vector2dF& page_scale_factor_limits,
259 const gfx::SizeF& content_size, 259 const gfx::SizeF& content_size,
260 const gfx::SizeF& viewport_size, 260 const gfx::SizeF& viewport_size,
261 const float top_controls_height, 261 const float content_offset,
262 const float top_controls_shown_ratio, 262 const float top_shown_pix,
263 bool top_changed,
263 bool is_mobile_optimized_hint); 264 bool is_mobile_optimized_hint);
264 265
265 bool HasFocus(); 266 bool HasFocus();
266 void RequestDisallowInterceptTouchEvent(); 267 void RequestDisallowInterceptTouchEvent();
267 void OnGestureEventAck(const blink::WebGestureEvent& event, 268 void OnGestureEventAck(const blink::WebGestureEvent& event,
268 InputEventAckState ack_result); 269 InputEventAckState ack_result);
269 bool FilterInputEvent(const blink::WebInputEvent& event); 270 bool FilterInputEvent(const blink::WebInputEvent& event);
270 271
271 // Shows the disambiguation popup 272 // Shows the disambiguation popup
272 // |rect_pixels| --> window coordinates which |zoomed_bitmap| represents 273 // |rect_pixels| --> window coordinates which |zoomed_bitmap| represents
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 scoped_refptr<GinJavaBridgeDispatcherHost> java_bridge_dispatcher_host_; 381 scoped_refptr<GinJavaBridgeDispatcherHost> java_bridge_dispatcher_host_;
381 382
382 DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl); 383 DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl);
383 }; 384 };
384 385
385 bool RegisterContentViewCore(JNIEnv* env); 386 bool RegisterContentViewCore(JNIEnv* env);
386 387
387 } // namespace content 388 } // namespace content
388 389
389 #endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_ 390 #endif // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698