Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: components/domain_reliability/monitor_unittest.cc

Issue 284103003: Domain Reliability: Don't use error code unless request failed (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/domain_reliability/monitor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/monitor_unittest.cc
diff --git a/components/domain_reliability/monitor_unittest.cc b/components/domain_reliability/monitor_unittest.cc
index 84f3067d2fd12f2a5df5cbdb85dba3180dfb8609..3ccbdc0815007e3d915630dcadadb682dba024e6 100644
--- a/components/domain_reliability/monitor_unittest.cc
+++ b/components/domain_reliability/monitor_unittest.cc
@@ -315,7 +315,6 @@ TEST_F(DomainReliabilityMonitorTest, ClearBeacons) {
EXPECT_TRUE(CheckRequestCounts(kNeverReportIndex, 0u, 0u));
}
-
TEST_F(DomainReliabilityMonitorTest, ClearContexts) {
// Initially the monitor should have just the test context.
EXPECT_EQ(1u, monitor_.contexts_size_for_testing());
@@ -326,6 +325,20 @@ TEST_F(DomainReliabilityMonitorTest, ClearContexts) {
EXPECT_EQ(0u, monitor_.contexts_size_for_testing());
}
+TEST_F(DomainReliabilityMonitorTest, IgnoreSuccessError) {
+ RequestInfo request = MakeRequestInfo();
+ request.url = GURL("http://example/always_report");
+ request.status.set_error(net::ERR_QUIC_PROTOCOL_ERROR);
+ OnRequestLegComplete(request);
+
+ EXPECT_EQ(1u, CountPendingBeacons(kAlwaysReportIndex));
+ EXPECT_TRUE(CheckRequestCounts(kAlwaysReportIndex, 1u, 0u));
+
+ BeaconVector beacons;
+ context_->GetQueuedDataForTesting(kAlwaysReportIndex, &beacons, NULL, NULL);
+ EXPECT_EQ(net::OK, beacons[0].chrome_error);
+}
+
} // namespace
} // namespace domain_reliability
« no previous file with comments | « components/domain_reliability/monitor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698