Domain Reliability: Don't use error code unless request failed

components/domain_reliability/monitor_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/domain_reliability/monitor.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 297 matching lines @@
   monitor_.ClearBrowsingData(CLEAR_BEACONS);
 
   // Make sure the beacon was cleared, but not the contexts.
   EXPECT_EQ(1u, monitor_.contexts_size_for_testing());
   EXPECT_EQ(0u, CountPendingBeacons(kAlwaysReportIndex));
   EXPECT_TRUE(CheckRequestCounts(kAlwaysReportIndex, 0u, 0u));
   EXPECT_EQ(0u, CountPendingBeacons(kNeverReportIndex));
   EXPECT_TRUE(CheckRequestCounts(kNeverReportIndex, 0u, 0u));
 }
 
-
 TEST_F(DomainReliabilityMonitorTest, ClearContexts) {
   // Initially the monitor should have just the test context.
   EXPECT_EQ(1u, monitor_.contexts_size_for_testing());
 
   monitor_.ClearBrowsingData(CLEAR_CONTEXTS);
 
   // Clearing contexts should leave the monitor with none.
   EXPECT_EQ(0u, monitor_.contexts_size_for_testing());
 }
 
+TEST_F(DomainReliabilityMonitorTest, IgnoreSuccessError) {
+  RequestInfo request = MakeRequestInfo();
+  request.url = GURL("http://example/always_report");
+  request.status.set_error(net::ERR_QUIC_PROTOCOL_ERROR);
+  OnRequestLegComplete(request);
+
+  EXPECT_EQ(1u, CountPendingBeacons(kAlwaysReportIndex));
+  EXPECT_TRUE(CheckRequestCounts(kAlwaysReportIndex, 1u, 0u));
+
+  BeaconVector beacons;
+  context_->GetQueuedDataForTesting(kAlwaysReportIndex, &beacons, NULL, NULL);
+  EXPECT_EQ(net::OK, beacons[0].chrome_error);
+}
+
 }  // namespace
 
 }  // namespace domain_reliability