Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: components/domain_reliability/monitor.cc

Issue 284103003: Domain Reliability: Don't use error code unless request failed (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/domain_reliability/monitor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/domain_reliability/monitor.cc
diff --git a/components/domain_reliability/monitor.cc b/components/domain_reliability/monitor.cc
index 410121329a07ae3829458034c93dec59358e2721..3f0c1ff34bf655c41bf55ebfb2b85e0163257cfc 100644
--- a/components/domain_reliability/monitor.cc
+++ b/components/domain_reliability/monitor.cc
@@ -221,6 +221,10 @@ void DomainReliabilityMonitor::OnRequestLegComplete(
ContextMap::iterator context_it;
std::string beacon_status;
+ int error_code = net::OK;
+ if (request.status.status() == net::URLRequestStatus::FAILED)
+ error_code = request.status.error();
+
// Ignore requests where:
// 1. There is no context for the request host.
// 2. The request did not access the network.
@@ -234,13 +238,13 @@ void DomainReliabilityMonitor::OnRequestLegComplete(
(request.load_flags & net::LOAD_DO_NOT_SEND_COOKIES) ||
request.is_upload ||
!GetDomainReliabilityBeaconStatus(
- request.status.error(), response_code, &beacon_status)) {
+ error_code, response_code, &beacon_status)) {
return;
}
DomainReliabilityBeacon beacon;
beacon.status = beacon_status;
- beacon.chrome_error = request.status.error();
+ beacon.chrome_error = error_code;
if (!request.response_info.was_fetched_via_proxy)
beacon.server_ip = request.response_info.socket_address.host();
else
« no previous file with comments | « no previous file | components/domain_reliability/monitor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698