chrome/browser/extensions/extension_disabled_ui.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_disabled_ui.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/management/management_api.cc ('K') | « chrome/browser/extensions/extension_context_menu_model.cc ('k') | chrome/browser/extensions/extension_gcm_app_handler_unittest.cc » ('j') | chrome/browser/extensions/extension_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_disabled_ui.cc

diff --git a/chrome/browser/extensions/extension_disabled_ui.cc b/chrome/browser/extensions/extension_disabled_ui.cc

index ece2144a677674b42c38b75b017a167c1bc1add8..82d69f01233c54b6c75262aec426a3d254b8d73b 100644

--- a/chrome/browser/extensions/extension_disabled_ui.cc

+++ b/chrome/browser/extensions/extension_disabled_ui.cc

@@ -306,7 +306,10 @@ void ExtensionDisabledGlobalError::BubbleViewCancelButtonPressed(

}

void ExtensionDisabledGlobalError::ExtensionUninstallAccepted() {

- service_->UninstallExtension(extension_->id(), false, NULL);

+ service_->UninstallExtension(

+ extension_->id(),

+ ExtensionService::kUninstallReasonUserInitiated,

Devlin 2014/05/14 23:14:20 Looking at this more, maybe we want to differentia

rpaquay 2014/06/30 23:16:18 I created a new enum entry for this case.

+ NULL);

}

void ExtensionDisabledGlobalError::ExtensionUninstallCanceled() {