Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

chrome/browser/extensions/extension_disabled_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_disabled_ui.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
@@ skipping 288 matching lines @@
       ExtensionUninstallDialog::Create(service_->profile(), browser, this));
   // Delay showing the uninstall dialog, so that this function returns
   // immediately, to close the bubble properly. See crbug.com/121544.
   base::MessageLoop::current()->PostTask(FROM_HERE,
       base::Bind(&ExtensionUninstallDialog::ConfirmUninstall,
                  uninstall_dialog_->AsWeakPtr(), extension_));
 #endif  // !defined(OS_ANDROID)
 }
 
 void ExtensionDisabledGlobalError::ExtensionUninstallAccepted() {
-  service_->UninstallExtension(extension_->id(), false, NULL);
+  service_->UninstallExtension(
+      extension_->id(),
+      ExtensionService::kUninstallReasonUserInitiated,

[Devlin, 2014/05/14 23:14:20]

Looking at this more, maybe we want to differentiate between "UserInitiated" and
"UserConfirmed".  This isn't initiated by the user, but the user is aware of it.

[rpaquay, 2014/06/30 23:16:18]

I created a new enum entry for this case.

+      NULL);
 }
 
 void ExtensionDisabledGlobalError::ExtensionUninstallCanceled() {
   // Nothing happens, and the error is still there.
 }
 
 void ExtensionDisabledGlobalError::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
@@ skipping 49 matching lines @@
 void ShowExtensionDisabledDialog(ExtensionService* service,
                                  content::WebContents* web_contents,
                                  const Extension* extension) {
   scoped_ptr<ExtensionInstallPrompt> install_ui(
       new ExtensionInstallPrompt(web_contents));
   // This object manages its own lifetime.
   new ExtensionDisabledDialogDelegate(service, install_ui.Pass(), extension);
 }
 
 }  // namespace extensions