chrome/browser/extensions/api/management/management_api.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc ('k') | chrome/browser/extensions/extension_browsertest.cc » ('j') | chrome/browser/extensions/extension_disabled_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index 86f67ef9684dfffc23e434167800577d11766a4e..7f55ae1316b639ccbd41db8da434adc446be42b7 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -581,9 +581,7 @@ void ManagementUninstallFunctionBase::SetAutoConfirmForTest(

void ManagementUninstallFunctionBase::Finish(bool should_uninstall) {

if (should_uninstall) {

bool success = service()->UninstallExtension(

- extension_id_,

- false, /* external uninstall */

- NULL);

+ extension_id_, ExtensionService::kUninstallReasonDefault, NULL);

Devlin 2014/05/14 23:14:20 I think ManagementAPI should more likely be user i

not at google - send to devlin 2014/05/14 23:17:02 If somebody writes an extension management extensi

rpaquay 2014/06/30 23:16:18 Done.

// TODO set error_ if !success

SendResponse(success);