Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

chrome/browser/extensions/api/management/management_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/management/management_api.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 563 matching lines @@
 
 // static
 void ManagementUninstallFunctionBase::SetAutoConfirmForTest(
     bool should_proceed) {
   auto_confirm_for_test = should_proceed ? PROCEED : ABORT;
 }
 
 void ManagementUninstallFunctionBase::Finish(bool should_uninstall) {
   if (should_uninstall) {
     bool success = service()->UninstallExtension(
-        extension_id_,
-        false, /* external uninstall */
-        NULL);
+        extension_id_, ExtensionService::kUninstallReasonDefault, NULL);

[Devlin, 2014/05/14 23:14:20]

I think ManagementAPI should more likely be user initiated, in most cases.  The
API will always pop up a "Do you wish to uninstall?" dialog, unless it's
uninstalling the extension which called it.  Of course, we don't necessarily
know what causes the prompt to be displayed, so a UninstallReasonAPI could also
make sense.  In either case, we probably want to separate from Default here.

[not at google - send to devlin, 2014/05/14 23:17:02]

If somebody writes an extension management extension then uninstalls from that
should be treated like uninstalls from chrome://extensions (consider also that
the developer tool uses the management API).

I.e. if it went through the uninstall UI, it should be considered initiated by
the user (unlike an extension uninstalling itself).

[rpaquay, 2014/06/30 23:16:18]

Done.

 
     // TODO set error_ if !success
     SendResponse(success);
   } else {
     error_ = ErrorUtils::FormatErrorMessage(
         keys::kUninstallCanceledError, extension_id_);
     SendResponse(false);
   }
 
 }
@@ skipping 217 matching lines @@
   return g_factory.Pointer();
 }
 
 void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) {
   management_event_router_.reset(
       new ManagementEventRouter(Profile::FromBrowserContext(browser_context_)));
   EventRouter::Get(browser_context_)->UnregisterObserver(this);
 }
 
 }  // namespace extensions