chrome/browser/ui/app_list/search/app_search_provider_unittest.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/search/app_search_provider_unittest.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/app_list/search/app_search_provider_unittest.cc

diff --git a/chrome/browser/ui/app_list/search/app_search_provider_unittest.cc b/chrome/browser/ui/app_list/search/app_search_provider_unittest.cc

index f3d5582e4596c3e37e02ea530328bf6c44594076..451eb5b7d669516bc4ae1676e49b6443dd25c58b 100644

--- a/chrome/browser/ui/app_list/search/app_search_provider_unittest.cc

+++ b/chrome/browser/ui/app_list/search/app_search_provider_unittest.cc

@@ -84,7 +84,8 @@ TEST_F(AppSearchProviderTest, DisableAndEnable) {

TEST_F(AppSearchProviderTest, Uninstall) {

EXPECT_EQ("Packaged App 1", RunQuery("pa1"));

- service_->UninstallExtension(kPackagedApp1Id, false, NULL);

+ service_->UninstallExtension(

+ kPackagedApp1Id, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

EXPECT_EQ("", RunQuery("pa1"));

// Let uninstall code to clean up.

« no previous file with comments | « chrome/browser/ui/app_list/extension_uninstaller.cc ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »