chrome/browser/ui/app_list/extension_uninstaller.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/extension_uninstaller.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc ('k') | chrome/browser/ui/app_list/search/app_search_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/extension_uninstaller.cc

diff --git a/chrome/browser/ui/app_list/extension_uninstaller.cc b/chrome/browser/ui/app_list/extension_uninstaller.cc

index a60a744c1ad8315419a67b8684b31a46b62e4cfe..dd4b23f3f87d0f59a7bf44ceec98d328b682900c 100644

--- a/chrome/browser/ui/app_list/extension_uninstaller.cc

+++ b/chrome/browser/ui/app_list/extension_uninstaller.cc

@@ -42,9 +42,8 @@ void ExtensionUninstaller::ExtensionUninstallAccepted() {

const extensions::Extension* extension =

service->GetInstalledExtension(app_id_);

if (extension) {

- service->UninstallExtension(app_id_,

- false, /* external_uninstall*/

- NULL);

+ service->UninstallExtension(

+ app_id_, ExtensionService::UNINSTALL_REASON_USER_INITIATED, NULL);

}

controller_->OnCloseChildDialog();

CleanUp();