chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_syncable_service.cc ('k') | chrome/browser/ui/app_list/extension_uninstaller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc

diff --git a/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc b/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc

index fb23569f414ea7bcaa1082519f2621c2e2031c61..ae70cbbad86e9c8fb8ef9988ca352832a57cf006 100644

--- a/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc

+++ b/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc

@@ -196,7 +196,8 @@ TEST_F(ExtensionAppModelBuilderTest, DisableAndEnable) {

}

TEST_F(ExtensionAppModelBuilderTest, Uninstall) {

- service_->UninstallExtension(kPackagedApp2Id, false, NULL);

+ service_->UninstallExtension(

+ kPackagedApp2Id, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

EXPECT_EQ(std::string("Packaged App 1,Hosted App"),

GetModelContent(model_.get()));

@@ -211,7 +212,8 @@ TEST_F(ExtensionAppModelBuilderTest, UninstallTerminatedApp) {

// Simulate an app termination.

service_->TrackTerminatedExtensionForTest(app);

- service_->UninstallExtension(kPackagedApp2Id, false, NULL);

+ service_->UninstallExtension(

+ kPackagedApp2Id, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

EXPECT_EQ(std::string("Packaged App 1,Hosted App"),

GetModelContent(model_.get()));

« no previous file with comments | « chrome/browser/ui/app_list/app_list_syncable_service.cc ('k') | chrome/browser/ui/app_list/extension_uninstaller.cc » ('j') | no next file with comments »