Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1718)

Unified Diff: chrome/browser/extensions/external_install_error.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_install_error.cc
diff --git a/chrome/browser/extensions/external_install_error.cc b/chrome/browser/extensions/external_install_error.cc
index 6b35e5454bfb0e917947cfd0f89379506902db93..27a8ee44135cc4b930ad4bc9fb99310b74959d37 100644
--- a/chrome/browser/extensions/external_install_error.cc
+++ b/chrome/browser/extensions/external_install_error.cc
@@ -284,9 +284,10 @@ void ExternalInstallError::InstallUIAbort(bool user_initiated) {
if (user_initiated && GetExtension()) {
ExtensionSystem::Get(browser_context_)
->extension_service()
- ->UninstallExtension(extension_id_,
- false, // Not externally uninstalled.
- NULL); // Ignore error.
+ ->UninstallExtension(
+ extension_id_,
+ ExtensionService::UNINSTALL_REASON_INSTALL_CANCELED,
+ NULL); // Ignore error.
// Since the manager listens for the extension to be removed, this will
// remove the error...
} else {
« no previous file with comments | « chrome/browser/extensions/extension_sync_service.cc ('k') | chrome/browser/extensions/shared_module_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698