chrome/browser/extensions/shared_module_service.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/shared_module_service.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/external_install_error.cc ('k') | chrome/browser/extensions/shared_module_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/shared_module_service.cc

diff --git a/chrome/browser/extensions/shared_module_service.cc b/chrome/browser/extensions/shared_module_service.cc

index 05d28046ac345f41e3abad10e5834c5015d81887..8474d247606f238d64c1423e83c5d176a7222e13 100644

--- a/chrome/browser/extensions/shared_module_service.cc

+++ b/chrome/browser/extensions/shared_module_service.cc

@@ -152,9 +152,10 @@ void SharedModuleService::OnExtensionUninstalled(

scoped_ptr<ExtensionSet> dependents =

GetDependentExtensions(imported_module);

if (dependents->is_empty()) {

- service->UninstallExtension(iter->extension_id,

- true, // External uninstall.

- NULL); // Ignore error.

+ service->UninstallExtension(

+ iter->extension_id,

+ ExtensionService::UNINSTALL_REASON_ORPHANED_SHARED_MODULE,

+ NULL); // Ignore error.

}

« no previous file with comments | « chrome/browser/extensions/external_install_error.cc ('k') | chrome/browser/extensions/shared_module_service_unittest.cc » ('j') | no next file with comments »