Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2102)

Unified Diff: chrome/browser/extensions/extension_sync_service.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_sync_service.cc
diff --git a/chrome/browser/extensions/extension_sync_service.cc b/chrome/browser/extensions/extension_sync_service.cc
index b125e728df6b034b8d1b6bdcfeb33066eca3e16e..e1b1af255e5dff72fecab9ba397e0ab9e31bd38f 100644
--- a/chrome/browser/extensions/extension_sync_service.cc
+++ b/chrome/browser/extensions/extension_sync_service.cc
@@ -449,7 +449,8 @@ bool ExtensionSyncService::ProcessExtensionSyncDataHelper(
// Handle uninstalls first.
if (extension_sync_data.uninstalled()) {
- if (!extension_service_->UninstallExtensionHelper(extension_service_, id)) {
+ if (!extension_service_->UninstallExtensionHelper(
+ extension_service_, id, ExtensionService::UNINSTALL_REASON_SYNC)) {
LOG(WARNING) << "Could not uninstall extension " << id
<< " for sync";
}
« no previous file with comments | « chrome/browser/extensions/extension_storage_monitor.cc ('k') | chrome/browser/extensions/external_install_error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698