chrome/browser/extensions/extension_storage_monitor.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_storage_monitor.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_storage_monitor.cc

diff --git a/chrome/browser/extensions/extension_storage_monitor.cc b/chrome/browser/extensions/extension_storage_monitor.cc

index 750caaa3951dd5653d716fc1d009eb55c48a8099..b03ed58d4bf94f9cfafaff30d76b68b84f82cf8a 100644

--- a/chrome/browser/extensions/extension_storage_monitor.cc

+++ b/chrome/browser/extensions/extension_storage_monitor.cc

@@ -319,7 +319,10 @@ void ExtensionStorageMonitor::ExtensionUninstallAccepted() {

ExtensionService* service =

ExtensionSystem::Get(context_)->extension_service();

DCHECK(service);

- service->UninstallExtension(extension->id(), false, NULL);

+ service->UninstallExtension(

+ extension->id(),

+ ExtensionService::UNINSTALL_REASON_STORAGE_THRESHOLD_EXCEEDED,

+ NULL);

}

void ExtensionStorageMonitor::ExtensionUninstallCanceled() {

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_sync_service.cc » ('j') | no next file with comments »