chrome/browser/extensions/extension_gcm_app_handler_unittest.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_disabled_ui.cc ('k') | chrome/browser/extensions/extension_message_bubble_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

diff --git a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

index 43fefca3f1cb4c7f8b38e57494e6d8d46b563e42..ca12a24d80b57664038e4aa95a8b0c06ba11b8c2 100644

--- a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

+++ b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

@@ -333,7 +333,8 @@ class ExtensionGCMAppHandlerTest : public testing::Test {

}

void UninstallExtension(const Extension* extension) {

- extension_service_->UninstallExtension(extension->id(), false, NULL);

+ extension_service_->UninstallExtension(

+ extension->id(), ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

}

void SignIn(const std::string& username) {