Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6070)

Unified Diff: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
diff --git a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
index 082d662dd44acf90b6a51e0a4008bcb88556faf5..5f206a085b4783e9e2514cf4749a704e49e9c10c 100644
--- a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
+++ b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
@@ -720,9 +720,12 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_SettingsApiControllerTest) {
EXPECT_FALSE(prefs->HasSettingsApiBubbleBeenAcknowledged(kId3));
// Clean up after ourselves.
- service_->UninstallExtension(kId1, false, NULL);
- service_->UninstallExtension(kId2, false, NULL);
- service_->UninstallExtension(kId3, false, NULL);
+ service_->UninstallExtension(
+ kId1, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
+ service_->UninstallExtension(
+ kId2, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
+ service_->UninstallExtension(
+ kId3, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
}
}
@@ -819,9 +822,12 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_NtpOverriddenControllerTest) {
EXPECT_FALSE(prefs->HasNtpOverriddenBubbleBeenAcknowledged(kId3));
// Clean up after ourselves.
- service_->UninstallExtension(kId1, false, NULL);
- service_->UninstallExtension(kId2, false, NULL);
- service_->UninstallExtension(kId3, false, NULL);
+ service_->UninstallExtension(
+ kId1, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
+ service_->UninstallExtension(
+ kId2, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
+ service_->UninstallExtension(
+ kId3, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
}
void SetInstallTime(const std::string& extension_id,
@@ -939,9 +945,12 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_ProxyOverriddenControllerTest) {
EXPECT_FALSE(prefs->HasProxyOverriddenBubbleBeenAcknowledged(kId3));
// Clean up after ourselves.
- service_->UninstallExtension(kId1, false, NULL);
- service_->UninstallExtension(kId2, false, NULL);
- service_->UninstallExtension(kId3, false, NULL);
+ service_->UninstallExtension(
+ kId1, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
+ service_->UninstallExtension(
+ kId2, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
+ service_->UninstallExtension(
+ kId3, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
}
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/extension_gcm_app_handler_unittest.cc ('k') | chrome/browser/extensions/extension_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698