Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: chrome/browser/extensions/extension_disabled_ui.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_disabled_ui.cc
diff --git a/chrome/browser/extensions/extension_disabled_ui.cc b/chrome/browser/extensions/extension_disabled_ui.cc
index b2c8a513f2bf326ed5538ecd5a011347a3df7f86..e3b3ea75c36314215ac4b5d7a40ad24618391b9a 100644
--- a/chrome/browser/extensions/extension_disabled_ui.cc
+++ b/chrome/browser/extensions/extension_disabled_ui.cc
@@ -365,7 +365,10 @@ bool ExtensionDisabledGlobalError::ShouldCloseOnDeactivate() const {
}
void ExtensionDisabledGlobalError::ExtensionUninstallAccepted() {
- service_->UninstallExtension(extension_->id(), false, NULL);
+ service_->UninstallExtension(
+ extension_->id(),
+ ExtensionService::UNINSTALL_REASON_EXTENSION_DISABLED,
+ NULL);
}
void ExtensionDisabledGlobalError::ExtensionUninstallCanceled() {

Powered by Google App Engine
This is Rietveld 408576698