Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7872)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/app_list/search/app_search_provider_unittest.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address code review feedback. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/search/hotword_service.cc ('K') | « chrome/browser/ui/app_list/extension_uninstaller.cc ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/search/app_search_provider_unittest.cc
diff --git a/chrome/browser/ui/app_list/search/app_search_provider_unittest.cc b/chrome/browser/ui/app_list/search/app_search_provider_unittest.cc
index f3d5582e4596c3e37e02ea530328bf6c44594076..6e7b902abc4a0247ba35ef27105a3e4412ee02b8 100644
--- a/chrome/browser/ui/app_list/search/app_search_provider_unittest.cc
+++ b/chrome/browser/ui/app_list/search/app_search_provider_unittest.cc
@@ -84,7 +84,8 @@ TEST_F(AppSearchProviderTest, DisableAndEnable) {
TEST_F(AppSearchProviderTest, Uninstall) {
EXPECT_EQ("Packaged App 1", RunQuery("pa1"));
- service_->UninstallExtension(kPackagedApp1Id, false, NULL);
+ service_->UninstallExtension(
+ kPackagedApp1Id, ExtensionService::UNINSTALL_REASON_DEFAULT, NULL);
EXPECT_EQ("", RunQuery("pa1"));
// Let uninstall code to clean up.
« chrome/browser/search/hotword_service.cc ('K') | « chrome/browser/ui/app_list/extension_uninstaller.cc ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698