Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6443)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address code review feedback. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/search/hotword_service.cc ('K') | « chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc b/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc
index e1a66c8f5f9b45265ab30965103ba6952a5f23d9..608442a009a2dbe005b4305a0bb9f80c8109b085 100644
--- a/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc
@@ -207,7 +207,7 @@ void BookmarkAppBubbleView::WindowClosing() {
if (remove_app_) {
GetExtensionService(profile_)->UninstallExtension(
- extension_id_, false, NULL);
+ extension_id_, ExtensionService::UNINSTALL_REASON_DEFAULT, NULL);
Devlin 2014/07/01 17:39:10 See comment in hotword.
rpaquay 2014/07/01 22:56:53 Done.
} else {
ApplyEdits();
}
« chrome/browser/search/hotword_service.cc ('K') | « chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698