Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

chrome/browser/search/hotword_service.cc

Index: chrome/browser/search/hotword_service.cc
diff --git a/chrome/browser/search/hotword_service.cc b/chrome/browser/search/hotword_service.cc
index f7f8aeddb8ebf2d4bf0b360ea86f9d669160dc1f..0a84dbde3d9d92b6ccd72d4d581944b1106a087b 100644
--- a/chrome/browser/search/hotword_service.cc
+++ b/chrome/browser/search/hotword_service.cc
@@ -360,7 +360,9 @@ bool HotwordService::UninstallHotwordExtension(
     ExtensionService* extension_service) {
   base::string16 error;
   if (!extension_service->UninstallExtension(
-          extension_misc::kHotwordExtensionId, true, &error)) {
+          extension_misc::kHotwordExtensionId,
+          ExtensionService::UNINSTALL_REASON_DEFAULT,

[Devlin, 2014/07/01 17:39:10]

This one's tricky.  I'd love to get rid of DEFAULT and rename it to TESTING, but
this is also used for updating itself.  Hmm... I wonder if we should have a
UNINSTALL_REASON_INTERNAL_MANAGEMENT for this stuff.  It would be used for
Hotword, Bookmarks, and maybe the Drive one.  Unfortunately, I'm not entirely
sure that's a much more specific name than "DEFAULT".  WDYT?

[rpaquay, 2014/07/01 22:56:53]

I like the "internal management" idea. I added a comment next to the new entry.

+          &error)) {
     LOG(WARNING) << "Cannot uninstall extension with id "
                  << extension_misc::kHotwordExtensionId
                  << ": " << error;